Use os.remove() instead of shutil.rmtree() since the latter actually does follow pseudo-symlinks on…

dart/tools/make_links.py

 #!/usr/bin/env python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 
 '''Tool for creating symlinks from SOURCES to TARGET.
 
 For each SOURCE in SOURCES create a link from SOURCE to TARGET.  If a
 SOURCE ends with .../lib, the lib suffix is ignored when determining
@@ skipping 45 matching lines @@
     dir_name = os.path.dirname(options.timestamp_file)
     if not os.path.exists(dir_name):
       os.mkdir(dir_name)
     open(options.timestamp_file, 'w').close()
 
 
 def main(argv):
   (options, args) = get_options()
   target = os.path.relpath(args[0])
   if os.path.exists(target):
-    # Remove the packages directory if it already exists.
-    # This is necessary, otherwise we can end up having links in there
+    # If the packages directory already exists, delete the current links inside
+    # it. This is necessary, otherwise we can end up having links in there
     # pointing to directories which no longer exist (on incremental builds).
-    print 'Removing %s' % target
-    shutil.rmtree(target)
-  os.makedirs(target)
+    for link in os.listdir(target):
+      os.remove(os.path.join(target, link))

[kustermann, 2013/10/23 08:10:29]

If os.remove() raises on these pseudo-symlinks, I'll do another CL which calls
some shell command.

+  else:
+    os.makedirs(target)
   for source in args[1:]:
     # Assume the source directory is named ".../NAME/lib".
     (name, lib) = os.path.split(source)
     if lib != 'lib':
       name = source
     # Remove any addtional path components preceding NAME.
     (path, name) = os.path.split(name)
     if utils.GuessOS() == 'win32':
       source = os.path.relpath(source)
     else:
       source = os.path.relpath(source, start=target)
     exit_code = make_link(source, os.path.join(target, name))
     if exit_code != 0:
       return exit_code
   create_timestamp_file(options)
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))