Issue 321043003: Native method name mismatch cleanups for Dartium 36 roll.

Issue 321043003: Native method name mismatch cleanups for Dartium 36 roll. (Closed)

Created:
6 years, 6 months ago by Jacob

Modified:
6 years, 6 months ago

Reviewers:
Leaf, Emily Fortuna

CC:
reviews_dartlang.org, ricow1, vsm

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Native method name mismatch cleanups for Dartium 36 roll. BUG= R=efortuna@google.com, leafp@google.com Committed: https://code.google.com/p/dart/source/detail?r=37142

Patch Set 2 : PTAL #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+134 lines, -505 lines)			Patch
M	sdk/lib/_blink/dartium/_blink_dartium.dart	View		25 chunks	+7 lines, -119 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		13 chunks	+11 lines, -139 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		13 chunks	+1 line, -123 lines	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View		3 chunks	+0 lines, -18 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View		3 chunks	+0 lines, -24 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View		8 chunks	+0 lines, -41 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View		9 chunks	+0 lines, -40 lines	0 comments	Download
M	tools/dom/idl/dart/dart.idl	View		1 chunk	+99 lines, -0 lines	2 comments	Download
M	tools/dom/scripts/systemnative.py	View	1	1 chunk	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jacob

Most of these changes just remove entries from IDL that were removed in Dartium36. A ...

6 years, 6 months ago (2014-06-09 21:58:17 UTC) #1

Emily Fortuna

lgtm, but with one question https://codereview.chromium.org/321043003/diff/20001/tools/dom/idl/dart/dart.idl File tools/dom/idl/dart/dart.idl (right): https://codereview.chromium.org/321043003/diff/20001/tools/dom/idl/dart/dart.idl#newcode493 tools/dom/idl/dart/dart.idl:493: [Suppressed] readonly attribute AudioParam ...

6 years, 6 months ago (2014-06-09 22:22:44 UTC) #3

Jacob

https://codereview.chromium.org/321043003/diff/20001/tools/dom/idl/dart/dart.idl File tools/dom/idl/dart/dart.idl (right): https://codereview.chromium.org/321043003/diff/20001/tools/dom/idl/dart/dart.idl#newcode493 tools/dom/idl/dart/dart.idl:493: [Suppressed] readonly attribute AudioParam gain; On 2014/06/09 22:22:44, Emily ...

6 years, 6 months ago (2014-06-09 22:28:41 UTC) #4

Jacob

6 years, 6 months ago (2014-06-09 22:31:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r37142 (presubmit successful).

Expand Messages | Collapse Messages