Issue 319283003: Refactor dart:_blink into classes to improve startup time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 319283003: Refactor dart:_blink into classes to improve startup time (Closed)

Created:
6 years, 6 months ago by Leaf

Modified:
6 years, 6 months ago

Reviewers:
vsm, Jacob, kasperl

CC:
reviews_dartlang.org, ricow1, siva

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Refactor dart:_blink into classes to improve startup time. This CL reduces the snapshot size by about 20% (580kb). BUG= R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=37189

Created: 6 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8728 lines, -7522 lines)			Patch
M	sdk/lib/_blink/dartium/_blink_dartium.dart	View	1 2 3 4	2 chunks	+5083 lines, -3905 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		468 chunks	+2388 lines, -2388 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	1 2 3 4	10 chunks	+72 lines, -72 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	1 2 3 4	113 chunks	+712 lines, -712 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View	1 2 3 4	23 chunks	+148 lines, -148 lines	0 comments	Download
M	sdk/lib/web_gl/dartium/web_gl_dartium.dart	View	1 2 3 4	10 chunks	+182 lines, -182 lines	0 comments	Download
M	sdk/lib/web_sql/dartium/web_sql_dartium.dart	View	1 2 3 4	7 chunks	+14 lines, -14 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	1 2 3 4	4 chunks	+7 lines, -9 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	1 2 3 4	16 chunks	+46 lines, -26 lines	0 comments	Download
M	tools/dom/src/blink_native_DOMImplementation.dart	View	1 2 3 4	1 chunk	+38 lines, -28 lines	0 comments	Download
M	tools/dom/src/html_native_DOMImplementation.dart	View	1 2 3 4	6 chunks	+24 lines, -24 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1 2 3 4	1 chunk	+14 lines, -14 lines	0 comments	Download

Total messages: 4 (0 generated)

Leaf

Committed patchset #5 manually as r37189 (presubmit successful).

6 years, 6 months ago (2014-06-10 17:38:37 UTC) #3

Message was sent while issue was closed.

Is this a merge-to-trunk candidate?