Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: tools/dom/scripts/htmldartgenerator.py

Issue 319283003: Refactor dart:_blink into classes to improve startup time (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/web_sql/dartium/web_sql_dartium.dart ('k') | tools/dom/scripts/systemnative.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/htmldartgenerator.py
diff --git a/tools/dom/scripts/htmldartgenerator.py b/tools/dom/scripts/htmldartgenerator.py
index c81be535ae65e56b779034ad232b2d66f0e17298..76be9053682cc778e0e400bbb6afeae63ed1ebcb 100644
--- a/tools/dom/scripts/htmldartgenerator.py
+++ b/tools/dom/scripts/htmldartgenerator.py
@@ -438,7 +438,7 @@ class HtmlDartGenerator(object):
return is_optional(operations[signature_index], argument)
emitter = \
- self._native_library_emitter if self._dart_use_blink \
+ self._native_class_emitter if self._dart_use_blink \
else self._members_emitter
self._GenerateOverloadDispatcher(
@@ -548,9 +548,7 @@ class HtmlDartGenerator(object):
version, signature_index, argument_count):
name = emitter.Format('_create_$VERSION', VERSION=version)
if self._dart_use_blink:
- qualified_name = \
- "_".join(["Native",self._interface.id,
- name + 'constructorCallback'])
+ qualified_name = self.DeriveNativeName(name + 'constructorCallback')
else:
qualified_name = emitter.Format(
'$FACTORY.$NAME',
@@ -577,11 +575,11 @@ class HtmlDartGenerator(object):
PARAMS=constructor_info.ParametersAsDeclaration(self._DartType))
if self._dart_use_blink:
- overload_emitter = self._native_library_emitter
+ overload_emitter = self._native_class_emitter
mname = constructor_full_name.replace(".", "_")
- blink_name = \
- "_".join(["Native",self._interface.id, mname])
- qual_name = self._native_library_name + "." + blink_name
+ blink_name = "$mk" + mname
+ qual_name = self.DeriveQualifiedBlinkName(
+ self._interface.id, blink_name)
actuals_s = constructor_info.ParametersAsStringOfVariables()
self._members_emitter.Emit(
'\n'
@@ -591,7 +589,7 @@ class HtmlDartGenerator(object):
ACTUALS=actuals_s)
overload_declaration = emitter.Format(
'// Generated overload resolver\n'
- '$CTOR($PARAMS)',
+ ' static $CTOR($PARAMS)',
CTOR=blink_name,
PARAMS=actuals_s)
« no previous file with comments | « sdk/lib/web_sql/dartium/web_sql_dartium.dart ('k') | tools/dom/scripts/systemnative.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698