Detect and wrap JS-CustomEvents if applicable. Include created_watcher and

Detect and wrap JS-CustomEvents if applicable. Include created_watcher and
update a couple dependencies.

R=jmesserly@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37182

[Siggi Cherem (dart-lang), 2014-06-06 22:42:25]

https://codereview.chromium.org/317013007/diff/20001/pkg/polymer/lib/src/even...
File pkg/polymer/lib/src/events.dart (right):

https://codereview.chromium.org/317013007/diff/20001/pkg/polymer/lib/src/even...
pkg/polymer/lib/src/events.dart:61: if (e is CustomEvent) {
this part was a regression, I think (we used to check for e is CustomEvent, but
I didn't realize this got deleted in the new roll).

https://codereview.chromium.org/317013007/diff/20001/pkg/web_components/pubsp...
File pkg/web_components/pubspec.yaml (right):

https://codereview.chromium.org/317013007/diff/20001/pkg/web_components/pubsp...
pkg/web_components/pubspec.yaml:2: version: 0.3.5-dev
I'll update the other CL actually, turns out we haven't released 0.3.5, so no
need to got o 0.3.6-dev yet.

[justinfagnani, 2014-06-06 23:37:05]

https://codereview.chromium.org/317013007/diff/20001/pkg/polymer/lib/src/even...
File pkg/polymer/lib/src/events.dart (right):

https://codereview.chromium.org/317013007/diff/20001/pkg/polymer/lib/src/even...
pkg/polymer/lib/src/events.dart:65: if (detail == null) {
I'm confused by this, are the Dart detail and the JS detail using separate
storage?

[Jennifer Messerly, 2014-06-09 16:54:37]

Can we add a test for CustomEvent?

https://codereview.chromium.org/317013007/diff/20001/pkg/polymer/lib/src/even...
File pkg/polymer/lib/src/events.dart (right):

https://codereview.chromium.org/317013007/diff/20001/pkg/polymer/lib/src/even...
pkg/polymer/lib/src/events.dart:61: if (e is CustomEvent) {
On 2014/06/06 22:42:24, Siggi Cherem (dart-lang) wrote:
> this part was a regression, I think (we used to check for e is CustomEvent,
but
> I didn't realize this got deleted in the new roll).

ah, right... it should've been:

    var detail = e is CustomEvent ? e.detail : null;

Should I make a quick patch for it w/ regression test?

https://codereview.chromium.org/317013007/diff/20001/pkg/polymer/lib/src/even...
pkg/polymer/lib/src/events.dart:65: if (detail == null) {
On 2014/06/06 23:37:05, justinfagnani wrote:
> I'm confused by this, are the Dart detail and the JS detail using separate
> storage?

for some reason, CustomEvent is a bit wacky in dart:html (see below). but yeah,
I would expect it to be non-null for JS objects...

@DomName('CustomEvent')
class CustomEvent extends Event {
  var _dartDetail;

  factory CustomEvent(String type,
      {bool canBubble: true, bool cancelable: true, Object detail}) {

    final CustomEvent e = document._createEvent('CustomEvent');

    e._dartDetail = detail;

    // Only try setting the detail if it's one of these types to avoid
    // first-chance exceptions. Can expand this list in the future as needed.
    if (detail is List || detail is Map || detail is String || detail is num) {
      try {
        e._initCustomEvent(type, canBubble, cancelable, detail);
      } catch(_) {
        e._initCustomEvent(type, canBubble, cancelable, null);
      }
    } else {
      e._initCustomEvent(type, canBubble, cancelable, null);
    }

    return e;
  }

  @DomName('CustomEvent.detail')
  get detail {
    if (_dartDetail != null) {
      return _dartDetail;
    }
    return _detail;
  }
  // To suppress missing implicit constructor warnings.
  factory CustomEvent._() { throw new UnsupportedError("Not supported"); }

  @DomName('CustomEvent.detail')
  @DocsEditable()
  Object get _detail => _blink.Native_CustomEvent_detail_Getter(this);

  @DomName('CustomEvent.initCustomEvent')
  @DocsEditable()
  void _initCustomEvent(String typeArg, bool canBubbleArg, bool cancelableArg,
Object detailArg) => _blink.Native_CustomEvent_initCustomEvent_Callback(this,
typeArg, canBubbleArg, cancelableArg, detailArg);

}

[Siggi Cherem (dart-lang), 2014-06-10 01:39:34]

PTAL

https://codereview.chromium.org/317013007/diff/20001/pkg/polymer/lib/src/even...
File pkg/polymer/lib/src/events.dart (right):

https://codereview.chromium.org/317013007/diff/20001/pkg/polymer/lib/src/even...
pkg/polymer/lib/src/events.dart:61: if (e is CustomEvent) {
On 2014/06/09 16:54:37, John Messerly wrote:
> On 2014/06/06 22:42:24, Siggi Cherem (dart-lang) wrote:
> > this part was a regression, I think (we used to check for e is CustomEvent,
> but
> > I didn't realize this got deleted in the new roll).
> 
> ah, right... it should've been:
> 
>     var detail = e is CustomEvent ? e.detail : null;
> 
> Should I make a quick patch for it w/ regression test?

I think that's OK. The current test I'm adding should cover this too.

https://codereview.chromium.org/317013007/diff/20001/pkg/polymer/lib/src/even...
pkg/polymer/lib/src/events.dart:65: if (detail == null) {
On 2014/06/09 16:54:37, John Messerly wrote:
> On 2014/06/06 23:37:05, justinfagnani wrote:
> > I'm confused by this, are the Dart detail and the JS detail using separate
> > storage?
> 
> for some reason, CustomEvent is a bit wacky in dart:html (see below). but
yeah,
> I would expect it to be non-null for JS objects...
> 
> @DomName('CustomEvent')
> class CustomEvent extends Event {
>   var _dartDetail;
> 
>   factory CustomEvent(String type,
>       {bool canBubble: true, bool cancelable: true, Object detail}) {
> 
>     final CustomEvent e = document._createEvent('CustomEvent');
> 
>     e._dartDetail = detail;
> 
>     // Only try setting the detail if it's one of these types to avoid
>     // first-chance exceptions. Can expand this list in the future as needed.
>     if (detail is List || detail is Map || detail is String || detail is num)
{
>       try {
>         e._initCustomEvent(type, canBubble, cancelable, detail);
>       } catch(_) {
>         e._initCustomEvent(type, canBubble, cancelable, null);
>       }
>     } else {
>       e._initCustomEvent(type, canBubble, cancelable, null);
>     }
> 
>     return e;
>   }
> 
>   @DomName('CustomEvent.detail')
>   get detail {
>     if (_dartDetail != null) {
>       return _dartDetail;
>     }
>     return _detail;
>   }
>   // To suppress missing implicit constructor warnings.
>   factory CustomEvent._() { throw new UnsupportedError("Not supported"); }
> 
>   @DomName('CustomEvent.detail')
>   @DocsEditable()
>   Object get _detail => _blink.Native_CustomEvent_detail_Getter(this);
> 
>   @DomName('CustomEvent.initCustomEvent')
>   @DocsEditable()
>   void _initCustomEvent(String typeArg, bool canBubbleArg, bool cancelableArg,
> Object detailArg) => _blink.Native_CustomEvent_initCustomEvent_Callback(this,
> typeArg, canBubbleArg, cancelableArg, detailArg);
> 
> }

Seems like the scenario I hit when wrapping a core element was including a DOM
node in the detail.

[Jennifer Messerly, 2014-06-10 01:55:45]

lgtm

[Siggi Cherem (dart-lang), 2014-06-10 14:58:39]

Committed patchset #3 manually as r37182 (presubmit successful).