Detect and wrap JS-CustomEvents if applicable. Include created_watcher and

pkg/polymer/lib/src/events.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Code from declaration/events.js
 part of polymer;
 
 /// An extension of [polymer_expressions.PolymerExpressions] that adds support
 /// for binding events using `on-eventName` using [PolymerEventBindings].
 // TODO(jmesserly): the JS layering is a bit odd, with polymer-dev implementing
@@ skipping 39 matching lines @@
     }
     return node is ShadowRoot ? node.host : null;
   }
 
   EventListener getEventHandler(controller, target, String method) => (e) {
     if (controller == null || controller is! Polymer) {
       controller = findController(target);
     }
 
     if (controller is Polymer) {
-      var args = [e, e.detail, e.currentTarget];
+      var detail = null;
+      if (e is CustomEvent) {

[Siggi Cherem (dart-lang), 2014/06/06 22:42:24]

this part was a regression, I think (we used to check for e is CustomEvent, but
I didn't realize this got deleted in the new roll).

[Jennifer Messerly, 2014/06/09 16:54:37]

ah, right... it should've been:

    var detail = e is CustomEvent ? e.detail : null;

Should I make a quick patch for it w/ regression test?

[Siggi Cherem (dart-lang), 2014/06/10 01:39:34]

I think that's OK. The current test I'm adding should cover this too.

+        detail = e.detail;
+        // Dart note: to improve interop with polymer.js elements, we try to
+        // proxy any js detail objects.
+        if (detail == null) {

[justinfagnani, 2014/06/06 23:37:05]

I'm confused by this, are the Dart detail and the JS detail using separate
storage?

[Jennifer Messerly, 2014/06/09 16:54:37]

for some reason, CustomEvent is a bit wacky in dart:html (see below). but yeah,
I would expect it to be non-null for JS objects...

@DomName('CustomEvent')
class CustomEvent extends Event {
  var _dartDetail;

  factory CustomEvent(String type,
      {bool canBubble: true, bool cancelable: true, Object detail}) {

    final CustomEvent e = document._createEvent('CustomEvent');

    e._dartDetail = detail;

    // Only try setting the detail if it's one of these types to avoid
    // first-chance exceptions. Can expand this list in the future as needed.
    if (detail is List || detail is Map || detail is String || detail is num) {
      try {
        e._initCustomEvent(type, canBubble, cancelable, detail);
      } catch(_) {
        e._initCustomEvent(type, canBubble, cancelable, null);
      }
    } else {
      e._initCustomEvent(type, canBubble, cancelable, null);
    }

    return e;
  }

  @DomName('CustomEvent.detail')
  get detail {
    if (_dartDetail != null) {
      return _dartDetail;
    }
    return _detail;
  }
  // To suppress missing implicit constructor warnings.
  factory CustomEvent._() { throw new UnsupportedError("Not supported"); }

  @DomName('CustomEvent.detail')
  @DocsEditable()
  Object get _detail => _blink.Native_CustomEvent_detail_Getter(this);

  @DomName('CustomEvent.initCustomEvent')
  @DocsEditable()
  void _initCustomEvent(String typeArg, bool canBubbleArg, bool cancelableArg,
Object detailArg) => _blink.Native_CustomEvent_initCustomEvent_Callback(this,
typeArg, canBubbleArg, cancelableArg, detailArg);

}

[Siggi Cherem (dart-lang), 2014/06/10 01:39:34]

Seems like the scenario I hit when wrapping a core element was including a DOM
node in the detail. 

+          detail = new JsObject.fromBrowserObject(e)['detail'];
+        }
+      }
+      var args = [e, detail, e.currentTarget];
       controller.dispatchMethod(controller, method, args);
     } else {
       throw new StateError('controller $controller is not a '
           'Dart polymer-element.');
     }
   };
 
   prepareEventBinding(String path, String name, Node node) {
     if (!_hasEventPrefix(name)) return null;
 
@@ skipping 69 matching lines @@
   return map;
 }();
 
 // Dart note: we need this function because we have additional renames JS does
 // not have. The JS renames are simply case differences, whereas we have ones
 // like doubleclick -> dblclick and stripping the webkit prefix.
 String _eventNameFromType(String eventType) {
   final result = _reverseEventTranslations[eventType];
   return result != null ? result : eventType;
 }