Issue 316623005: Fix a race condition in pub serve's exitOnClose test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 316623005: Fix a race condition in pub serve's exitOnClose test. (Closed)

Created:
6 years, 6 months ago by nweiz

Modified:
6 years, 6 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a race condition in pub serve's exitOnClose test. It was possible for the web socket to be closed before a response was sent to the exitOnClose request, causing the test (which expected such a response) to fail. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=36962

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -4 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/utils.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/web_socket/exit_on_close_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

6 years, 6 months ago (2014-06-03 23:37:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r36962 (presubmit successful).

Expand Messages | Collapse Messages