sdk/lib/_internal/pub/test/serve/utils.dart - Issue 316623005: Fix a race condition in pub serve's exitOnClose test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/serve/utils.dart

Issue 316623005: Fix a race condition in pub serve's exitOnClose test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart ('k') | sdk/lib/_internal/pub/test/serve/web_socket/exit_on_close_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/serve/utils.dart

diff --git a/sdk/lib/_internal/pub/test/serve/utils.dart b/sdk/lib/_internal/pub/test/serve/utils.dart

index 4ec4dc8f65751958d1722e3dabc8d81d4a2f23c1..725c3b4c21e2564516b53cfa84e2cc38a440c361 100644

--- a/sdk/lib/_internal/pub/test/serve/utils.dart

+++ b/sdk/lib/_internal/pub/test/serve/utils.dart

@@ -12,6 +12,7 @@ import 'package:http/http.dart' as http;

import 'package:scheduled_test/scheduled_process.dart';

import 'package:scheduled_test/scheduled_stream.dart';

import 'package:scheduled_test/scheduled_test.dart';

+import 'package:stack_trace/stack_trace.dart';

import '../../lib/src/utils.dart';

import '../descriptor.dart' as d;

@@ -443,8 +444,8 @@ Future<Map> _jsonRpcRequest(String method, [Map params]) {

if (params != null) message["params"] = params;

_webSocket.add(JSON.encode(message));

- return _webSocketBroadcastStream

- .firstWhere((response) => response["id"] == id).then((value) {

+ return Chain.track(_webSocketBroadcastStream

+ .firstWhere((response) => response["id"] == id)).then((value) {

currentSchedule.addDebugInfo(

"Web Socket request $method with params $params\n"

"Result: $value");