Make setDirectoryHandler and setErrorPageHandler setters, and add a jailRoot property.

Make setDirectoryHandler and setErrorPageHandler setters, and add a jailRoot property.

While being on by default, disabling jailRoot allows following links to
outside the root directory.

BUG=https://code.google.com/p/dart/issues/detail?id=14196,https://code.google.com/p/dart/issues/detail?id=14193
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28926

[Søren Gjesse, 2013-10-21 10:44:31]

lgtm

https://codereview.chromium.org/31633003/diff/1/pkg/http_server/lib/src/virtu...
File pkg/http_server/lib/src/virtual_directory.dart (right):

https://codereview.chromium.org/31633003/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_directory.dart:33: bool jailRoot = true;
I don't have better names ("confineToRoot" or "onlyServeInsideRoot" are probably
not any better).

https://codereview.chromium.org/31633003/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_directory.dart:126: print("Link target:
$target");
Debug print.

https://codereview.chromium.org/31633003/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_directory.dart:131: print(targetPath);
Ditto.

[Anders Johnsen, 2013-10-21 12:20:26]

Ty, landing.

https://codereview.chromium.org/31633003/diff/1/pkg/http_server/lib/src/virtu...
File pkg/http_server/lib/src/virtual_directory.dart (right):

https://codereview.chromium.org/31633003/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_directory.dart:33: bool jailRoot = true;
On 2013/10/21 10:44:31, Søren Gjesse wrote:
> I don't have better names ("confineToRoot" or "onlyServeInsideRoot" are
probably
> not any better).

Done.

https://codereview.chromium.org/31633003/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_directory.dart:126: print("Link target:
$target");
On 2013/10/21 10:44:31, Søren Gjesse wrote:
> Debug print.

Done.

https://codereview.chromium.org/31633003/diff/1/pkg/http_server/lib/src/virtu...
pkg/http_server/lib/src/virtual_directory.dart:131: print(targetPath);
On 2013/10/21 10:44:31, Søren Gjesse wrote:
> Ditto.

Done.

[Anders Johnsen, 2013-10-21 12:22:44]

Committed patchset #2 manually as r28926 (presubmit successful).