Make setDirectoryHandler and setErrorPageHandler setters, and add a jailRoot property.

pkg/http_server/test/virtual_directory_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:io';
 
 import "package:http_server/http_server.dart";
 import "package:path/path.dart";
 import "package:unittest/unittest.dart";
@@ skipping 193 matching lines @@
         });
       }
     });
 
     group('custom', () {
       test('simple', () {
         expect(HttpServer.bind('localhost', 0).then((server) {
           var dir = Directory.systemTemp.createTempSync('http_server_virtual_');
           var virDir = new VirtualDirectory(dir.path);
           virDir.allowDirectoryListing = true;
-          virDir.setDirectoryHandler((dir2, request) {
+          virDir.directoryHandler = (dir2, request) {
             expect(dir2, isNotNull);
             expect(FileSystemEntity.identicalSync(dir.path, dir2.path), isTrue);
             request.response.write('My handler ${request.uri.path}');
             request.response.close();
-          });
+          };
 
           virDir.serve(server);
 
           return getAsString(server.port, '/')
           .whenComplete(() {
             server.close();
             dir.deleteSync();
           });
         }), completion(contains('My handler /')));
       });
@@ skipping 41 matching lines @@
                 });
           }), completion(equals(HttpStatus.OK)));
         });
 
         group('bad-links', () {
           test('absolute-link', () {
             expect(HttpServer.bind('localhost', 0).then((server) {
               var dir =
                   Directory.systemTemp.createTempSync('http_server_virtual_');
               var file = new File('${dir.path}/file')..createSync();
-              var link = new Link('${dir.path}/dir3')
+              var link = new Link('${dir.path}/file2')
                   ..createSync('${dir.path}/file');
               var virDir = new VirtualDirectory(dir.path);
               virDir.followLinks = true;
 
               virDir.serve(server);
 
               return new HttpClient().get('localhost',
                                           server.port,
-                                          '/dir3/file')
+                                          '/file2')
                   .then((request) => request.close())
                   .then((response) => response.drain().then(
                       (_) => response.statusCode))
                   .whenComplete(() {
                     server.close();
                     dir.deleteSync(recursive: true);
                   });
             }), completion(equals(HttpStatus.NOT_FOUND)));
           });
 
           test('relative-parent-link', () {
             expect(HttpServer.bind('localhost', 0).then((server) {
               var dir =
                   Directory.systemTemp.createTempSync('http_server_virtual_');
-              var name = basename(dir.path);
+              var dir2 = new Directory('${dir.path}/dir')..createSync();
               var file = new File('${dir.path}/file')..createSync();
-              var link = new Link('${dir.path}/dir3')
-                  ..createSync('../$name/file');
-              var virDir = new VirtualDirectory(dir.path);
+              var link = new Link('${dir2.path}/file')
+                  ..createSync('../file');
+              var virDir = new VirtualDirectory(dir2.path);
               virDir.followLinks = true;
 
               virDir.serve(server);
 
               return new HttpClient().get('localhost',
                                           server.port,
                                           '/dir3/file')
                   .then((request) => request.close())
                   .then((response) => response.drain().then(
                       (_) => response.statusCode))
@@ skipping 20 matching lines @@
             virDir.serve(server);
 
             return getStatusCode(server.port, '/dir3/file')
                 .whenComplete(() {
                   server.close();
                   dir.deleteSync(recursive: true);
                 });
           }), completion(equals(HttpStatus.NOT_FOUND)));
         });
       });
+
+      group('follow-links', () {
+        test('no-root-jail', () {
+          test('absolute-link', () {
+            expect(HttpServer.bind('localhost', 0).then((server) {
+              var dir =
+                  Directory.systemTemp.createTempSync('http_server_virtual_');
+              var file = new File('${dir.path}/file')..createSync();
+              var link = new Link('${dir.path}/file2')
+                  ..createSync('${dir.path}/file');
+              var virDir = new VirtualDirectory(dir.path);
+              virDir.followLinks = true;
+              virDir.jailRoot = false;
+
+              virDir.serve(server);
+
+              return new HttpClient().get('localhost',
+                                          server.port,
+                                          '/file2')
+                  .then((request) => request.close())
+                  .then((response) => response.drain().then(
+                      (_) => response.statusCode))
+                  .whenComplete(() {
+                    server.close();
+                    dir.deleteSync(recursive: true);
+                  });
+            }), completion(equals(HttpStatus.OK)));
+          });
+
+          test('relative-parent-link', () {
+            expect(HttpServer.bind('localhost', 0).then((server) {
+              var dir =
+                  Directory.systemTemp.createTempSync('http_server_virtual_');
+              var dir2 = new Directory('${dir.path}/dir')..createSync();
+              var file = new File('${dir.path}/file')..createSync();
+              var link = new Link('${dir2.path}/file')
+                  ..createSync('../file');
+              var virDir = new VirtualDirectory(dir2.path);
+              virDir.followLinks = true;
+              virDir.jailRoot = false;
+
+              virDir.serve(server);
+
+              return new HttpClient().get('localhost',
+                                          server.port,
+                                          '/file')
+                  .then((request) => request.close())
+                  .then((response) => response.drain().then(
+                      (_) => response.statusCode))
+                  .whenComplete(() {
+                    server.close();
+                    dir.deleteSync(recursive: true);
+                  });
+            }), completion(equals(HttpStatus.OK)));
+          });
+        });
+      });
     }
   });
 
   group('last-modified', () {
     group('file', () {
       test('file-exists', () {
         expect(HttpServer.bind('localhost', 0).then((server) {
           var dir = Directory.systemTemp.createTempSync('http_server_virtual_');
           var file = new File('${dir.path}/file')..createSync();
           var virDir = new VirtualDirectory(dir.path);
@@ skipping 102 matching lines @@
             });
       }), completion(matches(new RegExp('404.*Not Found'))));
     });
 
     test('custom', () {
       expect(HttpServer.bind('localhost', 0).then((server) {
         var dir = Directory.systemTemp.createTempSync('http_server_virtual_');
         var virDir = new VirtualDirectory(dir.path);
         dir.deleteSync();
 
-        virDir.setErrorPageHandler((request) {
+        virDir.errorPageHandler = (request) {
           request.response.write('my-page ');
           request.response.write(request.response.statusCode);
           request.response.close();
-        });
+        };
         virDir.serve(server);
 
         return getAsString(server.port, '/')
             .whenComplete(() {
               server.close();
             });
       }), completion(equals('my-page 404')));
     });
   });
 
@@ skipping 120 matching lines @@
     }
     testEncoding('..', HttpStatus.NOT_FOUND, false);
     testEncoding('%2e%2e', HttpStatus.OK);
     testEncoding('%252e%252e', HttpStatus.OK);
     testEncoding('/', HttpStatus.OK, false);
     testEncoding('%2f', HttpStatus.NOT_FOUND, false);
     testEncoding('%2f', HttpStatus.OK, true);
   });
 }