Issue 315583002: First step in reducing the size of PC descriptors.

Issue 315583002: First step in reducing the size of PC descriptors. (Closed)

Created:
6 years, 6 months ago by Florian Schneider

Modified:
6 years, 6 months ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

First step in reducing the size of PC descriptors. The descriptors used for patching just contain a pc offset and can be stored with the code object instead of allocating a full descriptor and linearly searching the list to retrieve this information. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36989

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments, added arm64 file. #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -86 lines)			Patch
M	runtime/vm/code_patcher.cc	View	1	4 chunks	+5 lines, -9 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1	3 chunks	+9 lines, -13 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	1	3 chunks	+8 lines, -12 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1	3 chunks	+10 lines, -13 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1	3 chunks	+9 lines, -13 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	3 chunks	+9 lines, -13 lines	0 comments	Download
M	runtime/vm/object.h	View	1	3 chunks	+31 lines, -4 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	3 chunks	+13 lines, -7 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	1 chunk	+5 lines, -0 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/315583002/diff/1/runtime/vm/flow_graph_compiler.h File runtime/vm/flow_graph_compiler.h (right): https://codereview.chromium.org/315583002/diff/1/runtime/vm/flow_graph_compiler.h#newcode597 runtime/vm/flow_graph_compiler.h:597: intptr_t entry_patch_pc_; This three are pc offsets not ...

6 years, 6 months ago (2014-06-03 15:45:45 UTC) #2

Florian Schneider

https://codereview.chromium.org/315583002/diff/1/runtime/vm/flow_graph_compiler.h File runtime/vm/flow_graph_compiler.h (right): https://codereview.chromium.org/315583002/diff/1/runtime/vm/flow_graph_compiler.h#newcode597 runtime/vm/flow_graph_compiler.h:597: intptr_t entry_patch_pc_; On 2014/06/03 15:45:45, srdjan wrote: > This ...

6 years, 6 months ago (2014-06-04 10:59:14 UTC) #3

Florian Schneider

Committed patchset #2 manually as r36989 (presubmit successful).

6 years, 6 months ago (2014-06-04 11:02:44 UTC) #4

Ivan Posva

DBC -ip https://codereview.chromium.org/315583002/diff/20001/runtime/vm/raw_object.h File runtime/vm/raw_object.h (right): https://codereview.chromium.org/315583002/diff/20001/runtime/vm/raw_object.h#newcode844 runtime/vm/raw_object.h:844: intptr_t entry_patch_pc_offset_; Do these have to be ...

6 years, 6 months ago (2014-06-05 22:28:04 UTC) #5

Florian Schneider

6 years, 6 months ago (2014-06-06 08:54:27 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/315583002/diff/20001/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://codereview.chromium.org/315583002/diff/20001/runtime/vm/raw_object.h#...
runtime/vm/raw_object.h:844: intptr_t entry_patch_pc_offset_;
On 2014/06/05 22:28:04, Ivan Posva wrote:
> Do these have to be intptr_t or would a sized pointer suffice?

I guess int32_t would be enough for the size of generated code.

Expand Messages | Collapse Messages