Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: runtime/vm/code_patcher.cc

Issue 315583002: First step in reducing the size of PC descriptors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: addressed comments, added arm64 file. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | runtime/vm/raw_object.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_patcher.cc
===================================================================
--- runtime/vm/code_patcher.cc (revision 36988)
+++ runtime/vm/code_patcher.cc (working copy)
@@ -52,8 +52,7 @@
// The patch code buffer contains the jmp code which will be inserted at
// entry point.
void CodePatcher::PatchEntry(const Code& code) {
- const uword patch_addr = code.GetPcForDeoptId(Isolate::kNoDeoptId,
- PcDescriptors::kEntryPatch);
+ const uword patch_addr = code.GetEntryPatchPc();
ASSERT(patch_addr != 0);
JumpPattern jmp_entry(patch_addr, code);
ASSERT(!jmp_entry.IsValid());
@@ -77,8 +76,7 @@
// The entry point is a jmp instruction, the patch code buffer contains
// original code, the entry point contains the jump instruction.
void CodePatcher::RestoreEntry(const Code& code) {
- const uword patch_addr = code.GetPcForDeoptId(Isolate::kNoDeoptId,
- PcDescriptors::kEntryPatch);
+ const uword patch_addr = code.GetEntryPatchPc();
ASSERT(patch_addr != 0);
JumpPattern jmp_entry(patch_addr, code);
ASSERT(jmp_entry.IsValid());
@@ -102,8 +100,7 @@
bool CodePatcher::IsEntryPatched(const Code& code) {
- const uword patch_addr = code.GetPcForDeoptId(Isolate::kNoDeoptId,
- PcDescriptors::kEntryPatch);
+ const uword patch_addr = code.GetEntryPatchPc();
if (patch_addr == 0) {
return false;
}
@@ -113,9 +110,8 @@
bool CodePatcher::CodeIsPatchable(const Code& code) {
- const uword patch_addr = code.GetPcForDeoptId(Isolate::kNoDeoptId,
- PcDescriptors::kEntryPatch);
- // kEntryPatch may not exist which means the function is not patchable.
+ const uword patch_addr = code.GetEntryPatchPc();
+ // Zero means means that the function is not patchable.
if (patch_addr == 0) {
return false;
}
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | runtime/vm/raw_object.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698