Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 315223003: Use CallBootstrapC stub for leaf native calls. (Closed)

Created:
6 years, 6 months ago by Cutch
Modified:
6 years, 6 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use CallBootstrapC stub for leaf native calls. This removes a comparison and branch in the CallNativeC stub. R=asiva@google.com, iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37047

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -76 lines) Patch
M runtime/vm/intermediate_language_arm.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 3 chunks +8 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 2 3 4 2 chunks +0 lines, -12 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Cutch
6 years, 6 months ago (2014-06-05 16:22:03 UTC) #1
Ivan Posva
LGTMwC -Ivan https://codereview.chromium.org/315223003/diff/20001/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://codereview.chromium.org/315223003/diff/20001/runtime/vm/intermediate_language_ia32.cc#newcode811 runtime/vm/intermediate_language_ia32.cc:811: const bool is_leaf_call = Can you please ...
6 years, 6 months ago (2014-06-05 17:05:29 UTC) #2
siva
lgtm
6 years, 6 months ago (2014-06-05 17:32:50 UTC) #3
Cutch
https://codereview.chromium.org/315223003/diff/20001/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://codereview.chromium.org/315223003/diff/20001/runtime/vm/intermediate_language_ia32.cc#newcode811 runtime/vm/intermediate_language_ia32.cc:811: const bool is_leaf_call = On 2014/06/05 17:05:29, Ivan Posva ...
6 years, 6 months ago (2014-06-05 18:49:21 UTC) #4
Cutch
6 years, 6 months ago (2014-06-05 18:54:21 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 manually as r37047 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698