Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: runtime/vm/stub_code_mips.cc

Issue 315223003: Use CallBootstrapC stub for leaf native calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_ia32.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_mips.cc
diff --git a/runtime/vm/stub_code_mips.cc b/runtime/vm/stub_code_mips.cc
index 73744546c206099d5709d4d32db552d3caadab2a..154aadb7106beadbb21bb5bac23ea55fdd987083 100644
--- a/runtime/vm/stub_code_mips.cc
+++ b/runtime/vm/stub_code_mips.cc
@@ -229,11 +229,6 @@ void StubCode::GenerateCallNativeCFunctionStub(Assembler* assembler) {
__ sw(A0, Address(SP, 0 * kWordSize));
__ mov(A0, SP); // Pass the pointer to the NativeArguments.
- // Call native function (setup scope if not leaf function).
- Label leaf_call;
- Label done;
- __ AndImmediate(CMPRES1, A1, NativeArguments::AutoSetupScopeMask());
- __ beq(CMPRES1, ZR, &leaf_call);
__ mov(A1, T5); // Pass the function entrypoint.
__ ReserveAlignedFrameSpace(2 * kWordSize); // Just passing A0, A1.
@@ -248,19 +243,6 @@ void StubCode::GenerateCallNativeCFunctionStub(Assembler* assembler) {
__ BranchLink(&NativeEntry::NativeCallWrapperLabel());
#endif
__ TraceSimMsg("CallNativeCFunctionStub return");
- __ b(&done);
-
- __ Bind(&leaf_call);
- // Call native function or redirection via simulator.
- __ ReserveAlignedFrameSpace(kWordSize); // Just passing A0.
-
-
- // We defensively always jalr through T9 because it is sometimes required by
- // the MIPS ABI.
- __ mov(T9, T5);
- __ jalr(T9);
-
- __ Bind(&done);
// Mark that the isolate is executing Dart code.
__ LoadImmediate(A2, VMTag::kScriptTagId);
« no previous file with comments | « runtime/vm/stub_code_ia32.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698