Issue 312313002: Do not write protect code when running standalone. Improves startup performance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 312313002: Do not write protect code when running standalone. Improves startup performance. (Closed)

Created:
6 years, 6 months ago by srdjan

Modified:
6 years, 6 months ago

Reviewers:
Florian Schneider, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Do not write protect code when running standalone. Improves startup performance. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37032

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	runtime/bin/main.cc	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

Committed patchset #2 manually as r37032 (presubmit successful).

6 years, 6 months ago (2014-06-05 16:56:49 UTC) #3

Florian Schneider

6 years, 6 months ago (2014-06-06 09:03:45 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/312313002/diff/10001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/312313002/diff/10001/runtime/bin/main.cc#newc...
runtime/bin/main.cc:941: vm_options.AddArgument("--no_write_protect_code");
Does that mean we lose test coverage with write protection when running VM
tests?

Expand Messages | Collapse Messages