Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: runtime/bin/main.cc

Issue 312313002: Do not write protect code when running standalone. Improves startup performance. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include <stdlib.h> 5 #include <stdlib.h>
6 #include <string.h> 6 #include <string.h>
7 #include <stdio.h> 7 #include <stdio.h>
8 8
9 #include "include/dart_api.h" 9 #include "include/dart_api.h"
10 #include "include/dart_debugger_api.h" 10 #include "include/dart_debugger_api.h"
(...skipping 920 matching lines...) Expand 10 before | Expand all | Expand 10 after
931 } 931 }
932 932
933 933
934 void main(int argc, char** argv) { 934 void main(int argc, char** argv) {
935 char* script_name; 935 char* script_name;
936 CommandLineOptions vm_options(argc); 936 CommandLineOptions vm_options(argc);
937 CommandLineOptions dart_options(argc); 937 CommandLineOptions dart_options(argc);
938 bool print_flags_seen = false; 938 bool print_flags_seen = false;
939 bool verbose_debug_seen = false; 939 bool verbose_debug_seen = false;
940 940
941 vm_options.AddArgument("--no_write_protect_code");
Florian Schneider 2014/06/06 09:03:45 Does that mean we lose test coverage with write pr
941 // Perform platform specific initialization. 942 // Perform platform specific initialization.
942 if (!Platform::Initialize()) { 943 if (!Platform::Initialize()) {
943 Log::PrintErr("Initialization failed\n"); 944 Log::PrintErr("Initialization failed\n");
944 } 945 }
945 946
946 // On Windows, the argv strings are code page encoded and not 947 // On Windows, the argv strings are code page encoded and not
947 // utf8. We need to convert them to utf8. 948 // utf8. We need to convert them to utf8.
948 bool argv_converted = Utf8ConvertArgv(argc, argv); 949 bool argv_converted = Utf8ConvertArgv(argc, argv);
949 950
950 // Parse command line arguments. 951 // Parse command line arguments.
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
1166 exit(Process::GlobalExitCode()); 1167 exit(Process::GlobalExitCode());
1167 } 1168 }
1168 1169
1169 } // namespace bin 1170 } // namespace bin
1170 } // namespace dart 1171 } // namespace dart
1171 1172
1172 int main(int argc, char** argv) { 1173 int main(int argc, char** argv) {
1173 dart::bin::main(argc, argv); 1174 dart::bin::main(argc, argv);
1174 UNREACHABLE(); 1175 UNREACHABLE();
1175 } 1176 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698