Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 308703005: Extract constants into separate libarary. (Closed)

Created:
6 years, 6 months ago by scheglov
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Extract constants into separate libarary. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=36828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -388 lines) Patch
M pkg/analysis_server/lib/src/analysis_manager.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 5 chunks +9 lines, -28 lines 0 comments Download
A pkg/analysis_server/lib/src/constants.dart View 1 chunk +77 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 5 chunks +17 lines, -171 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_context.dart View 5 chunks +6 lines, -90 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_server.dart View 5 chunks +6 lines, -30 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 12 chunks +38 lines, -37 lines 0 comments Download
M pkg/analysis_server/test/domain_context_test.dart View 3 chunks +9 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 5 chunks +7 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/physical_resource_provider_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/resource_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 4 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 6 months ago (2014-05-30 17:55:37 UTC) #1
Brian Wilkerson
LGTM
6 years, 6 months ago (2014-05-30 18:25:04 UTC) #2
scheglov
Committed patchset #1 manually as r36828 (presubmit successful).
6 years, 6 months ago (2014-05-30 18:37:53 UTC) #3
Paul Berry
6 years, 6 months ago (2014-05-30 18:39:43 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698