Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1773)

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 308703005: Extract constants into separate libarary. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/analysis_manager.dart ('k') | pkg/analysis_server/lib/src/constants.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/analysis_server.dart
diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart
index dc533166a399fb98cd1d27259575c3144918b09a..412dd64b8e035e230172c6b1bf600207fefe768b 100644
--- a/pkg/analysis_server/lib/src/analysis_server.dart
+++ b/pkg/analysis_server/lib/src/analysis_server.dart
@@ -8,6 +8,7 @@ import 'dart:async';
import 'package:analysis_server/src/analysis_logger.dart';
import 'package:analysis_server/src/channel.dart';
+import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/context_directory_manager.dart';
import 'package:analysis_server/src/domain_analysis.dart';
import 'package:analysis_server/src/protocol.dart';
@@ -53,26 +54,6 @@ class AnalysisServerContextDirectoryManager extends ContextDirectoryManager {
*/
class AnalysisServer {
/**
- * The name of the parameter whose value is a list of errors.
- */
- static const String ERRORS_PARAM = 'errors';
-
- /**
- * The name of the parameter whose value is a file path.
- */
- static const String FILE_PARAM = 'file';
-
- /**
- * The event name of the connected notification.
- */
- static const String CONNECTED_NOTIFICATION = 'server.connected';
-
- /**
- * The event name of the status notification.
- */
- static const String STATUS_NOTIFICATION = 'server.status';
-
- /**
* The channel from which requests are received and to which responses should
* be sent.
*/
@@ -146,7 +127,7 @@ class AnalysisServer {
contextDirectoryManager = new AnalysisServerContextDirectoryManager(this, resourceProvider);
AnalysisEngine.instance.logger = new AnalysisLogger();
running = true;
- Notification notification = new Notification(CONNECTED_NOTIFICATION);
+ Notification notification = new Notification(NOTIFICATION_CONNECTED);
channel.sendNotification(notification);
channel.listen(handleRequest, onDone: done, onError: error);
}
@@ -267,17 +248,17 @@ class AnalysisServer {
if (!source.isInSystemLibrary) {
// errors
{
- Notification notification = new Notification(AnalysisDomainHandler.ERRORS_NOTIFICATION);
- notification.setParameter(FILE_PARAM, source.fullName);
- notification.setParameter(ERRORS_PARAM, notice.errors.map(errorToJson).toList());
+ Notification notification = new Notification(NOTIFICATION_ERRORS);
+ notification.setParameter(FILE, source.fullName);
+ notification.setParameter(ERRORS, notice.errors.map(errorToJson).toList());
sendNotification(notification);
}
// highlights
if (dartUnit != null) {
- Notification notification = new Notification(AnalysisDomainHandler.HIGHLIGHTS_NOTIFICATION);
- notification.setParameter(FILE_PARAM, source.fullName);
+ Notification notification = new Notification(NOTIFICATION_HIGHLIGHTS);
+ notification.setParameter(FILE, source.fullName);
notification.setParameter(
- AnalysisDomainHandler.REGIONS_PARAM,
+ REGIONS,
new DartUnitHighlightsComputer(dartUnit).compute());
sendNotification(notification);
}
@@ -294,7 +275,7 @@ class AnalysisServer {
return;
}
lastStatusNotificationContextId = contextId;
- Notification notification = new Notification(STATUS_NOTIFICATION);
+ Notification notification = new Notification(NOTIFICATION_STATUS);
Map<String, Object> analysis = new Map();
if (contextId != null) {
analysis['analyzing'] = true;
« no previous file with comments | « pkg/analysis_server/lib/src/analysis_manager.dart ('k') | pkg/analysis_server/lib/src/constants.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698