Issue 307523002: Adds more ARM64 SIMD instructions.

Issue 307523002: Adds more ARM64 SIMD instructions. (Closed)

Created:
6 years, 7 months ago by zra

Modified:
6 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Adds more ARM64 SIMD instructions. Also, enables simd inlining for arm64. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=36694

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1042 lines, -36 lines)			Patch
M	runtime/vm/assembler_arm64.h	View	1	3 chunks	+51 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm64_test.cc	View	1	1 chunk	+569 lines, -0 lines	0 comments	Download
M	runtime/vm/constants_arm64.h	View	1	2 chunks	+17 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler_arm64.cc	View	1	2 chunks	+40 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1	6 chunks	+146 lines, -23 lines	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View	1	5 chunks	+183 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/307523002/diff/1/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc (right): https://codereview.chromium.org/307523002/diff/1/runtime/vm/assembler_arm64.cc#newcode896 runtime/vm/assembler_arm64.cc:896: ASSERT(vn != VTMP); vn -> vd

6 years, 7 months ago (2014-05-27 16:04:13 UTC) #2

zra

Thanks https://codereview.chromium.org/307523002/diff/1/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc (right): https://codereview.chromium.org/307523002/diff/1/runtime/vm/assembler_arm64.cc#newcode896 runtime/vm/assembler_arm64.cc:896: ASSERT(vn != VTMP); On 2014/05/27 16:04:13, regis wrote: ...

6 years, 7 months ago (2014-05-27 16:17:40 UTC) #3

zra

6 years, 7 months ago (2014-05-27 16:29:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r36694 (presubmit successful).

Expand Messages | Collapse Messages