- Use isolate where it is appropriate.

- Use isolate where it is appropriate.
- Do not emit an name for ExternalLabel.

R=johnmccutchan@google.com, srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36662

[Cutch, 2014-05-27 10:00:02]

lgtm with a couple comments

https://codereview.chromium.org/306483005/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/306483005/diff/1/runtime/vm/parser.cc#newcode308
runtime/vm/parser.cc:308: library_(Library::Handle(isolate_, Class::Handle(
Should this use isolate() instead of isolate_?

https://codereview.chromium.org/306483005/diff/1/runtime/vm/parser.cc#newcode886
runtime/vm/parser.cc:886: const Script& script = Script::Handle(isolate,
cls.script());
You can use: isolate() right?

[srdjan, 2014-05-27 10:00:53]

LGTM

I wonder if the code would be more readable if we'd define a macro a la:
#define NEW new(isolate())  ... or NEWi or similar.

https://codereview.chromium.org/306483005/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/306483005/diff/1/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:1410: const String& getter_name = String::ZoneHandle(
pass isolate to ZoneHandle as well

[Ivan Posva, 2014-05-27 10:15:52]

Thanks,
-Ivan

https://codereview.chromium.org/306483005/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/306483005/diff/1/runtime/vm/parser.cc#newcode308
runtime/vm/parser.cc:308: library_(Library::Handle(isolate_, Class::Handle(
On 2014/05/27 10:00:02, Cutch wrote:
> Should this use isolate() instead of isolate_?

This is in the constructor, so I use isolate_ like the other places above.

https://codereview.chromium.org/306483005/diff/1/runtime/vm/parser.cc#newcode886
runtime/vm/parser.cc:886: const Script& script = Script::Handle(isolate,
cls.script());
On 2014/05/27 10:00:02, Cutch wrote:
> You can use: isolate() right?

No, as this is a static method.

https://codereview.chromium.org/306483005/diff/1/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:1410: const String& getter_name = String::ZoneHandle(
On 2014/05/27 10:00:53, srdjan wrote:
> pass isolate to ZoneHandle as well

This change only dealt with Handle, even though there are some sprinkled
ZoneHandles adjusted. Different CL.

[Ivan Posva, 2014-05-27 10:16:12]

Committed patchset #1 manually as r36662 (presubmit successful).