Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: runtime/vm/intermediate_language_mips.cc

Issue 306483005: - Use isolate where it is appropriate. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_mips.cc
===================================================================
--- runtime/vm/intermediate_language_mips.cc (revision 36643)
+++ runtime/vm/intermediate_language_mips.cc (working copy)
@@ -261,7 +261,8 @@
LocationSummary* LoadLocalInstr::MakeLocationSummary(Isolate* isolate,
bool opt) const {
- return LocationSummary::Make(0,
+ return LocationSummary::Make(isolate,
+ 0,
Location::RequiresRegister(),
LocationSummary::kNoCall);
}
@@ -276,7 +277,8 @@
LocationSummary* StoreLocalInstr::MakeLocationSummary(Isolate* isolate,
bool opt) const {
- return LocationSummary::Make(1,
+ return LocationSummary::Make(isolate,
+ 1,
Location::SameAsFirstInput(),
LocationSummary::kNoCall);
}
@@ -293,7 +295,8 @@
LocationSummary* ConstantInstr::MakeLocationSummary(Isolate* isolate,
bool opt) const {
- return LocationSummary::Make(0,
+ return LocationSummary::Make(isolate,
+ 0,
Location::RequiresRegister(),
LocationSummary::kNoCall);
}
@@ -910,7 +913,8 @@
bool opt) const {
const intptr_t kNumInputs = 1;
// TODO(fschneider): Allow immediate operands for the char code.
- return LocationSummary::Make(kNumInputs,
+ return LocationSummary::Make(isolate,
+ kNumInputs,
Location::RequiresRegister(),
LocationSummary::kNoCall);
}
@@ -934,7 +938,8 @@
LocationSummary* StringToCharCodeInstr::MakeLocationSummary(Isolate* isolate,
bool opt) const {
const intptr_t kNumInputs = 1;
- return LocationSummary::Make(kNumInputs,
+ return LocationSummary::Make(isolate,
+ kNumInputs,
Location::RequiresRegister(),
LocationSummary::kNoCall);
}
@@ -988,7 +993,8 @@
LocationSummary* LoadUntaggedInstr::MakeLocationSummary(Isolate* isolate,
bool opt) const {
const intptr_t kNumInputs = 1;
- return LocationSummary::Make(kNumInputs,
+ return LocationSummary::Make(isolate,
+ kNumInputs,
Location::RequiresRegister(),
LocationSummary::kNoCall);
}
@@ -1004,7 +1010,8 @@
LocationSummary* LoadClassIdInstr::MakeLocationSummary(Isolate* isolate,
bool opt) const {
const intptr_t kNumInputs = 1;
- return LocationSummary::Make(kNumInputs,
+ return LocationSummary::Make(isolate,
+ kNumInputs,
Location::RequiresRegister(),
LocationSummary::kNoCall);
}
@@ -1807,7 +1814,7 @@
__ Bind(entry_label());
const Code& stub =
Code::Handle(StubCode::GetAllocationStubForClass(cls_));
- const ExternalLabel label(cls_.ToCString(), stub.EntryPoint());
+ const ExternalLabel label(stub.EntryPoint());
LocationSummary* locs = instruction_->locs();
locs->live_registers()->Remove(locs->out(0));
@@ -2213,7 +2220,7 @@
const Class& double_class = compiler->double_class();
const Code& stub =
Code::Handle(StubCode::GetAllocationStubForClass(double_class));
- const ExternalLabel label(double_class.ToCString(), stub.EntryPoint());
+ const ExternalLabel label(stub.EntryPoint());
LocationSummary* locs = instruction_->locs();
locs->live_registers()->Remove(locs->out(0));
@@ -2464,8 +2471,7 @@
__ TraceSimMsg("AllocateContextInstr");
__ LoadImmediate(temp, num_context_variables());
- const ExternalLabel label("alloc_context",
- StubCode::AllocateContextEntryPoint());
+ const ExternalLabel label(StubCode::AllocateContextEntryPoint());
compiler->GenerateCall(token_pos(),
&label,
PcDescriptors::kOther,
@@ -4629,7 +4635,8 @@
LocationSummary* CurrentContextInstr::MakeLocationSummary(Isolate* isolate,
bool opt) const {
- return LocationSummary::Make(0,
+ return LocationSummary::Make(isolate,
+ 0,
Location::RequiresRegister(),
LocationSummary::kNoCall);
}
@@ -4725,7 +4732,8 @@
LocationSummary* BooleanNegateInstr::MakeLocationSummary(Isolate* isolate,
bool opt) const {
- return LocationSummary::Make(1,
+ return LocationSummary::Make(isolate,
+ 1,
Location::RequiresRegister(),
LocationSummary::kNoCall);
}
@@ -4752,7 +4760,7 @@
__ TraceSimMsg("AllocateObjectInstr");
__ Comment("AllocateObjectInstr");
const Code& stub = Code::Handle(StubCode::GetAllocationStubForClass(cls()));
- const ExternalLabel label(cls().ToCString(), stub.EntryPoint());
+ const ExternalLabel label(stub.EntryPoint());
compiler->GenerateCall(token_pos(),
&label,
PcDescriptors::kOther,

Powered by Google App Engine
This is Rietveld 408576698