Issue 303673009: Create a ServiceObject for a socket

Issue 303673009: Create a ServiceObject for a socket (Closed)

Created:
6 years, 6 months ago by Cutch

Modified:
6 years, 6 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Create a ServiceObject for a socket R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=36735

Patch Set 4 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1801 lines, -1206 lines)			Patch
M	runtime/bin/socket_patch.dart	View	1 2	3 chunks	+34 lines, -15 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html	View	1 2 3	1 chunk	+76 lines, -20 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View	1 2 3	148 chunks	+675 lines, -541 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html	View	1 2 3	1 chunk	+76 lines, -20 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View	1 2 3	148 chunks	+675 lines, -541 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/io_view.html	View	1 2 3	1 chunk	+76 lines, -20 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/action_link.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/code_view.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/io_view.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/io_view.html	View	1	1 chunk	+76 lines, -20 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/isolate_summary.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/service/object.dart	View	1	3 chunks	+109 lines, -0 lines	0 comments	Download
D	runtime/bin/vmservice/client/resources.sh	View	1 2 3	1 chunk	+0 lines, -23 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

lgtm https://codereview.chromium.org/303673009/diff/20001/runtime/bin/socket_patch.dart File runtime/bin/socket_patch.dart (right): https://codereview.chromium.org/303673009/diff/20001/runtime/bin/socket_patch.dart#newcode1122 runtime/bin/socket_patch.dart:1122: localAddress = address.address.toString(); address.address is a string? https://codereview.chromium.org/303673009/diff/20001/runtime/bin/socket_patch.dart#newcode1128 ...

6 years, 6 months ago (2014-05-28 10:59:56 UTC) #2

Cutch

https://codereview.chromium.org/303673009/diff/20001/runtime/bin/socket_patch.dart File runtime/bin/socket_patch.dart (right): https://codereview.chromium.org/303673009/diff/20001/runtime/bin/socket_patch.dart#newcode1122 runtime/bin/socket_patch.dart:1122: localAddress = address.address.toString(); On 2014/05/28 10:59:57, Anders Johnsen wrote: ...

6 years, 6 months ago (2014-05-28 11:24:56 UTC) #3

Cutch

6 years, 6 months ago (2014-05-28 11:25:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r36735 (presubmit successful).

Expand Messages | Collapse Messages