runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart - Issue 303673009: Create a ServiceObject for a socket

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart

Issue 303673009: Create a ServiceObject for a socket (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart

diff --git a/runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart b/runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart

index 1c3ef11d23b2610e7771ff36bc2adcdc144300a4..ea60919aca7f5846b950914e933e6b080927181e 100644

--- a/runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart

+++ b/runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart

@@ -190,7 +190,8 @@ class IsolateProfileElement extends ObservatoryElement {

// We only want to expand a tree row if the target of the click is

// the table cell (passed in as target) or the span containing the

// expander symbol (#expand).

- if ((e.target.id != 'expand') && (e.target != target)) {

+ var eventTarget = e.target;

+ if ((eventTarget.id != 'expand') && (e.target != target)) {

// Target of click was not the expander span or the table cell.

return;

}