Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 303303002: Address TODOs and remove obsolete ones. (Closed)

Created:
6 years, 6 months ago by regis
Modified:
6 years, 6 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Address TODOs and remove obsolete ones. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=36813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -44 lines) Patch
M runtime/vm/ast_printer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 6 chunks +31 lines, -16 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M tests/language/optional_named_parameters_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
6 years, 6 months ago (2014-05-29 21:12:44 UTC) #1
hausner
lgtm
6 years, 6 months ago (2014-05-29 23:03:19 UTC) #2
regis
6 years, 6 months ago (2014-05-29 23:06:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36813 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698