Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: runtime/vm/stub_code_arm.cc

Issue 303303002: Address TODOs and remove obsolete ones. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/parser.cc ('k') | runtime/vm/stub_code_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_arm.cc
===================================================================
--- runtime/vm/stub_code_arm.cc (revision 36803)
+++ runtime/vm/stub_code_arm.cc (working copy)
@@ -210,8 +210,8 @@
ASSERT(retval_offset == 3 * kWordSize);
__ add(R3, FP, Operand(3 * kWordSize)); // Set retval in NativeArgs.
- // TODO(regis): Should we pass the structure by value as in runtime calls?
- // It would require changing Dart API for native functions.
+ // Passing the structure by value as in runtime calls would require changing
+ // Dart API for native functions.
// For now, space is reserved on the stack and we pass a pointer to it.
__ stm(IA, SP, (1 << R0) | (1 << R1) | (1 << R2) | (1 << R3));
__ mov(R0, Operand(SP)); // Pass the pointer to the NativeArguments.
@@ -331,8 +331,8 @@
ASSERT(retval_offset == 3 * kWordSize);
__ add(R3, FP, Operand(3 * kWordSize)); // Set retval in NativeArgs.
- // TODO(regis): Should we pass the structure by value as in runtime calls?
- // It would require changing Dart API for native functions.
+ // Passing the structure by value as in runtime calls would require changing
+ // Dart API for native functions.
// For now, space is reserved on the stack and we pass a pointer to it.
__ stm(IA, SP, (1 << R0) | (1 << R1) | (1 << R2) | (1 << R3));
__ mov(R0, Operand(SP)); // Pass the pointer to the NativeArguments.
@@ -480,9 +480,6 @@
kFirstLocalSlotFromFp + 1 - (kNumberOfCpuRegisters - R0);
// Result in R0 is preserved as part of pushing all registers below.
- // TODO(regis): Should we align the stack before pushing the fpu registers?
- // If we do, saved_r0_offset_from_fp is not constant anymore.
-
// Push registers in their enumeration order: lowest register number at
// lowest address.
__ PushList(kAllCpuRegistersList);
« no previous file with comments | « runtime/vm/parser.cc ('k') | runtime/vm/stub_code_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698