Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 300313002: Switch to using remote analysis server instead of local. (Closed)

Created:
6 years, 6 months ago by scheglov
Modified:
6 years, 6 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, ricow1, lukeechurch_gmail.com
Visibility:
Public.

Description

Switch to using remote analysis server instead of local. 1. Start remote server. 2. Set analysis roots. 3. Listen for and show errors. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=36750

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+835 lines, -141 lines) Patch
M editor/tools/plugins/com.google.dart.server/META-INF/MANIFEST.MF View 1 chunk +1 line, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisError.java View 1 chunk +75 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServerListener.java View 1 chunk +0 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/BroadcastAnalysisServerListener.java View 3 chunks +13 lines, -13 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ByteResponseStream.java View 1 chunk +4 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java View 8 chunks +80 lines, -32 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ResponseStream.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/StdioServerSocket.java View 1 chunk +2 lines, -0 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/AnalysisErrorImpl.java View 1 chunk +36 lines, -38 lines 0 comments Download
A editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationErrorsProcessor.java View 1 chunk +141 lines, -0 lines 2 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java View 2 chunks +23 lines, -0 lines 1 comment Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/AbstractRemoteServerTest.java View 2 chunks +11 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 2 chunks +36 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/TestAll.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/TestResponseStream.java View 2 chunks +40 lines, -6 lines 0 comments Download
A editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/processor/AnalysisErrorImplTest.java View 1 chunk +41 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/processor/NotificationErrorsProcessorTest.java View 1 chunk +141 lines, -0 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/processor/TestAll.java View 2 chunks +3 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/shared/TestAnalysisServerListener.java View 5 chunks +111 lines, -15 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java View 4 chunks +33 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/model/AnalysisServerData.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/ProjectManagerImpl.java View 2 chunks +10 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java View 2 chunks +17 lines, -9 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisMarkerManager_NEW.java View 6 chunks +6 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/analysis/model/InternalAnalysisServerTest.java View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 6 months ago (2014-05-28 17:07:15 UTC) #1
jwren
LGTM https://codereview.chromium.org/300313002/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java File editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java (right): https://codereview.chromium.org/300313002/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java#newcode272 editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java:272: public static JsonObject generateAnalysisSetAnalysisRoots(String id, List<String> included, Normally ...
6 years, 6 months ago (2014-05-28 17:31:15 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/300313002/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationErrorsProcessor.java File editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationErrorsProcessor.java (right): https://codereview.chromium.org/300313002/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationErrorsProcessor.java#newcode103 editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationErrorsProcessor.java:103: JsonObject paramsObject = response.get("params").getAsJsonObject(); These strings should be ...
6 years, 6 months ago (2014-05-28 17:36:39 UTC) #3
scheglov
6 years, 6 months ago (2014-05-28 17:42:45 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r36750 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698