Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java

Issue 300313002: Switch to using remote analysis server instead of local. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java
diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java
index 37a2d98ee150044d87fb51b566f48c50528aaf90..5cdb48afc3fddc0fbc9c15c92a7210007071ed2b 100644
--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java
+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/WorkspaceAnalysisServerListener.java
@@ -14,13 +14,19 @@
package com.google.dart.tools.core.internal.analysis.model;
-import com.google.dart.engine.error.AnalysisError;
+import com.google.dart.server.AnalysisError;
import com.google.dart.server.AnalysisServerError;
import com.google.dart.server.AnalysisServerListener;
import com.google.dart.server.AnalysisStatus;
import com.google.dart.server.HighlightRegion;
import com.google.dart.server.NavigationRegion;
import com.google.dart.server.Outline;
+import com.google.dart.tools.core.internal.builder.AnalysisMarkerManager_NEW;
+import com.google.dart.tools.core.internal.util.ResourceUtil;
+
+import org.eclipse.core.resources.IResource;
+
+import java.io.File;
/**
* Implementation of {@link AnalysisServerListener} for the Eclipse workspace.
@@ -33,14 +39,16 @@ public class WorkspaceAnalysisServerListener implements AnalysisServerListener {
}
@Override
- public void computedErrors(String file, AnalysisError[] errors) {
- // TODO(scheglov) restore or remove for the new API
-// dataImpl.internalComputedErrors(contextId, source, errors);
-// IResource resource = DartCore.getProjectManager().getResource(source);
-// if (resource != null) {
-// // TODO(scheglov) Analysis Server: LineInfo
-// AnalysisMarkerManager.getInstance().queueErrors(resource, null, errors);
-// }
+ public void computedErrors(String filePath, AnalysisError[] errors) {
+ dataImpl.internalComputedErrors(filePath, errors);
+ File file = new File(filePath);
+ if (file.exists()) {
+ IResource resource = ResourceUtil.getResource(file);
+ if (resource != null) {
+ // TODO(scheglov) Analysis Server: LineInfo
+ AnalysisMarkerManager_NEW.getInstance().queueErrors(resource, null, errors);
+ }
+ }
}
@Override

Powered by Google App Engine
This is Rietveld 408576698