Issue 299833011: ARM mint cleanups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 299833011: ARM mint cleanups (Closed)

Created:
6 years, 7 months ago by Cutch

Modified:
6 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

ARM mint cleanups Add comment about stack slot push order Add conditional flag to SignFill assembler macro BUG= R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=36606

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
M	runtime/vm/assembler_arm.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/assembler_arm.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM Thanks! https://codereview.chromium.org/299833011/diff/1/runtime/vm/flow_graph_compiler_arm.cc File runtime/vm/flow_graph_compiler_arm.cc (right): https://codereview.chromium.org/299833011/diff/1/runtime/vm/flow_graph_compiler_arm.cc#newcode1450 runtime/vm/flow_graph_compiler_arm.cc:1450: // lowest address. The order that the ...

6 years, 7 months ago (2014-05-23 22:09:07 UTC) #2

Cutch

6 years, 7 months ago (2014-05-24 05:54:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r36606 (presubmit successful).

Expand Messages | Collapse Messages

Issue 299833011: ARM mint cleanups (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages