Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 299823004: Upgrade Observatory to Polymer 0.10.x (Closed)

Created:
6 years, 7 months ago by Cutch
Modified:
6 years, 7 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, ricow1, turnidge, vm-dev_dartlang.org
Visibility:
Public.

Description

Upgrade Observatory to Polymer 0.10.x R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=36544

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15234 lines, -589 lines) Patch
M runtime/bin/bin.gypi View 1 2 3 3 chunks +5 lines, -1 line 0 comments Download
M runtime/bin/resources_sources.gypi View 1 2 3 1 chunk +2 lines, -67 lines 0 comments Download
M runtime/bin/vmservice/client/HACKING.txt View 1 2 3 1 chunk +7 lines, -9 lines 0 comments Download
D runtime/bin/vmservice/client/build.sh View 1 2 3 1 chunk +0 lines, -26 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 3 36 chunks +7445 lines, -158 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 3 35 chunks +7446 lines, -159 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/browser/interop.js View 1 2 3 1 chunk +4 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/action_link.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/breakpoint_list.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/class_ref.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/class_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/code_ref.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/code_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/collapsible_content.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/curly_block.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/error_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/eval_box.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/eval_link.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/field_ref.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/field_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/function_ref.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/function_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/heap_map.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/heap_profile.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_ref.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_profile.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_ref.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_summary.html View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/json_view.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/library_ref.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/library_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/nav_bar.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/observatory_application.html View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/observatory_element.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/response_viewer.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_inset.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_ref.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/service_error_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/service_exception_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/service_ref.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/service_view.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/sliding_checkbox.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/stack_frame.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/stack_trace.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/vm_ref.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/vm_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/polymer/boot.js View 1 2 3 1 chunk +143 lines, -6 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/polymer/polymer.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/polymer/src/js/polymer/AUTHORS View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/polymer/src/js/polymer/CONTRIBUTING.md View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/polymer/src/js/polymer/LICENSE View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/polymer/src/js/polymer/PATENTS View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/polymer/src/js/polymer/README.md View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/polymer/src/js/polymer/bower.json View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/polymer/src/js/polymer/build.log View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/polymer/src/js/polymer/polymer.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/polymer/src/js/polymer/polymer.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/polymer/src/js/polymer/polymer-body.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/polymer/src/js/polymer/polymer.concat.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/polymer/src/js/polymer/polymer.concat.js.map View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/polymer/src/js/polymer/polymer.js.map View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/polymer/src/js/use_native_dartium_shadowdom.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/web_components/build.log View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/web_components/dart_support.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/web_components/platform.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/web_components/platform.concat.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/web_components/platform.concat.js.map View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/bin/vmservice/client/deployed/web/packages/web_components/platform.js.map View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
runtime/bin/vmservice/client/dotdot.sh View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/app/chart.dart View 1 2 3 1 chunk +8 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/action_link.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/breakpoint_list.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/class_ref.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/class_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/code_ref.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/code_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/collapsible_content.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/curly_block.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/error_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/eval_box.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/eval_link.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/field_ref.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/field_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/function_ref.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/function_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/heap_map.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/heap_profile.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/instance_ref.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/instance_view.html View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_profile.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_ref.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_summary.dart View 1 2 3 1 chunk +8 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/json_view.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/library_ref.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/library_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/nav_bar.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/observatory_application.dart View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/observatory_application.html View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/observatory_element.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/response_viewer.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/script_inset.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/script_ref.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/script_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_error_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_exception_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_ref.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_view.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/sliding_checkbox.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/stack_frame.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/stack_trace.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/vm_ref.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/vm_view.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
runtime/bin/vmservice/client/notdotdot.sh View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/pubspec.yaml View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/web/index.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/web/index_devtools.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/web/main.dart View 1 2 3 2 chunks +5 lines, -6 lines 0 comments Download
M runtime/tools/create_resources.py View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Cutch
Upgraded Observatory to Polymer 0.10.x. Please note this includes deployed/ files which you shouldn't review.
6 years, 7 months ago (2014-05-21 15:37:15 UTC) #1
turnidge
lgtm, one question. https://codereview.chromium.org/299823004/diff/10001/runtime/bin/vmservice/client/lib/src/elements/collapsible_content.html File runtime/bin/vmservice/client/lib/src/elements/collapsible_content.html (right): https://codereview.chromium.org/299823004/diff/10001/runtime/bin/vmservice/client/lib/src/elements/collapsible_content.html#newcode16 runtime/bin/vmservice/client/lib/src/elements/collapsible_content.html:16: <script type="application/dart;component=1" src="collapsible_content.dart"></script> What's this component=1 ...
6 years, 7 months ago (2014-05-21 20:00:56 UTC) #2
Cutch
Note that this regresses the chart on the VM page. Polymer 0.10.x doesn't allow us ...
6 years, 7 months ago (2014-05-23 07:08:19 UTC) #3
Cutch
6 years, 7 months ago (2014-05-23 07:11:58 UTC) #4
Message was sent while issue was closed. 
Committed patchset #4 manually as r36544 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698