Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2198)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/isolate_summary.dart

Issue 299823004: Upgrade Observatory to Polymer 0.10.x (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/isolate_summary.dart
diff --git a/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.dart b/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.dart
index 7054ba18b5c549cf77f36e62bcfe44e7b43cc93d..53357828a13096ed48932552047d850539ccb81d 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/isolate_summary.dart
@@ -89,12 +89,19 @@ class IsolateCounterChartElement extends ObservatoryElement {
IsolateCounterChartElement.created() : super.created();
@published ObservableMap counters;
- CounterChart chart = new CounterChart();
+ CounterChart chart;
void countersChanged(oldValue) {
if (counters == null) {
return;
}
+ // Lazily create the chart.
+ if (GoogleChart.ready && chart == null) {
+ chart = new CounterChart();
+ }
+ if (chart == null) {
+ return;
+ }
chart.update(counters);
var element = shadowRoot.querySelector('#counterPieChart');
if (element != null) {

Powered by Google App Engine
This is Rietveld 408576698