Issue 298883009: Eliminate some unnecessary handle allocations in the compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 298883009: Eliminate some unnecessary handle allocations in the compiler. (Closed)

Created:
6 years, 7 months ago by Florian Schneider

Modified:
6 years, 7 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Eliminate some unnecessary handle allocations in the compiler. Eliminate duplicate code from PushArgumentInstr by using TemplateDefinition. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36626

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -82 lines)			Patch
M	runtime/vm/block_scheduler.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	11 chunks	+37 lines, -54 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	2 chunks	+8 lines, -9 lines	0 comments	Download
M	runtime/vm/parser.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Florian Schneider

6 years, 7 months ago (2014-05-26 09:53:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r36626 (presubmit successful).