Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Side by Side Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 298883009: Eliminate some unnecessary handle allocations in the compiler. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 // PC marker. 141 // PC marker.
142 builder->AddPcMarker(previous->code(), slot_ix++); 142 builder->AddPcMarker(previous->code(), slot_ix++);
143 builder->AddCallerFp(slot_ix++); 143 builder->AddCallerFp(slot_ix++);
144 builder->AddCallerPc(slot_ix++); 144 builder->AddCallerPc(slot_ix++);
145 145
146 // For the outermost environment, set the incoming arguments. 146 // For the outermost environment, set the incoming arguments.
147 for (intptr_t i = previous->fixed_parameter_count() - 1; i >= 0; i--) { 147 for (intptr_t i = previous->fixed_parameter_count() - 1; i >= 0; i--) {
148 builder->AddCopy(previous->ValueAt(i), previous->LocationAt(i), slot_ix++); 148 builder->AddCopy(previous->ValueAt(i), previous->LocationAt(i), slot_ix++);
149 } 149 }
150 150
151 const DeoptInfo& deopt_info = 151 return builder->CreateDeoptInfo(deopt_table);
152 DeoptInfo::Handle(builder->CreateDeoptInfo(deopt_table));
153 return deopt_info.raw();
154 } 152 }
155 153
156 154
157 void CompilerDeoptInfoWithStub::GenerateCode(FlowGraphCompiler* compiler, 155 void CompilerDeoptInfoWithStub::GenerateCode(FlowGraphCompiler* compiler,
158 intptr_t stub_ix) { 156 intptr_t stub_ix) {
159 // Calls do not need stubs, they share a deoptimization trampoline. 157 // Calls do not need stubs, they share a deoptimization trampoline.
160 ASSERT(reason() != ICData::kDeoptAtCall); 158 ASSERT(reason() != ICData::kDeoptAtCall);
161 Assembler* assem = compiler->assembler(); 159 Assembler* assem = compiler->assembler();
162 #define __ assem-> 160 #define __ assem->
163 __ Comment("Deopt stub for id %" Pd "", deopt_id()); 161 __ Comment("Deopt stub for id %" Pd "", deopt_id());
(...skipping 1621 matching lines...) Expand 10 before | Expand all | Expand 10 after
1785 __ movups(reg, Address(RSP, 0)); 1783 __ movups(reg, Address(RSP, 0));
1786 __ AddImmediate(RSP, Immediate(kFpuRegisterSize), PP); 1784 __ AddImmediate(RSP, Immediate(kFpuRegisterSize), PP);
1787 } 1785 }
1788 1786
1789 1787
1790 #undef __ 1788 #undef __
1791 1789
1792 } // namespace dart 1790 } // namespace dart
1793 1791
1794 #endif // defined TARGET_ARCH_X64 1792 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698