Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 298133006: Handle synchronous asset load errors in barback. (Closed)

Created:
6 years, 7 months ago by nweiz
Modified:
6 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle synchronous asset load errors in barback. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=36723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
M pkg/barback/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/barback/lib/src/graph/asset_cascade.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/barback/test/package_graph/errors_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/barback/test/utils.dart View 4 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 7 months ago (2014-05-27 22:45:46 UTC) #1
Bob Nystrom
lgtm
6 years, 7 months ago (2014-05-28 00:15:54 UTC) #2
nweiz
6 years, 7 months ago (2014-05-28 00:36:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r36723 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698