pkg/barback/lib/src/graph/asset_cascade.dart - Issue 298133006: Handle synchronous asset load errors in barback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/barback/lib/src/graph/asset_cascade.dart

Issue 298133006: Handle synchronous asset load errors in barback. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/barback/lib/src/graph/asset_cascade.dart

diff --git a/pkg/barback/lib/src/graph/asset_cascade.dart b/pkg/barback/lib/src/graph/asset_cascade.dart

index ca087857311d0197562301fec645e468ecba74a7..80d448ca772b7cd0378e2bd649512e4ad326914d 100644

--- a/pkg/barback/lib/src/graph/asset_cascade.dart

+++ b/pkg/barback/lib/src/graph/asset_cascade.dart

@@ -13,6 +13,7 @@ import '../asset/asset_set.dart';

import '../errors.dart';

import '../log.dart';

import '../transformer/transformer.dart';

+import '../utils.dart';

import '../utils/cancelable_future.dart';

import 'node_status.dart';

import 'node_streams.dart';

@@ -138,8 +139,8 @@ class AssetCascade {

// return out-of-date contents for the asset.

if (_loadingSources.containsKey(id)) _loadingSources[id].cancel();

- _loadingSources[id] =

- new CancelableFuture<Asset>(graph.provider.getAsset(id));

+ _loadingSources[id] = new CancelableFuture<Asset>(

+ syncFuture(() => graph.provider.getAsset(id)));

_loadingSources[id].whenComplete(() {

_loadingSources.remove(id);

}).then((asset) {

« no previous file with comments | « pkg/barback/CHANGELOG.md ('k') | pkg/barback/test/package_graph/errors_test.dart » ('j') | no next file with comments »