Issue 297753003: Ensure that YAML maps' map keys are order-independent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297753003: Ensure that YAML maps' map keys are order-independent. (Closed)

Created:
6 years, 7 months ago by nweiz

Modified:
6 years, 7 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ensure that YAML maps' map keys are order-independent. R=jmesserly@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=36399

Patch Set 2 : code review #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
M	pkg/yaml/CHANGELOG.md	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/yaml/lib/src/utils.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/yaml/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

https://codereview.chromium.org/297753003/diff/1/pkg/yaml/lib/src/utils.dart File pkg/yaml/lib/src/utils.dart (right): https://codereview.chromium.org/297753003/diff/1/pkg/yaml/lib/src/utils.dart#newcode23 pkg/yaml/lib/src/utils.dart:23: var equality = const SetEquality(); maybe use UnorderedIterableEquality and ...

6 years, 7 months ago (2014-05-20 22:51:24 UTC) #2

nweiz

6 years, 7 months ago (2014-05-20 22:58:54 UTC) #3

nweiz

6 years, 7 months ago (2014-05-20 23:14:09 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r36399 (presubmit successful).

Expand Messages | Collapse Messages

Issue 297753003: Ensure that YAML maps' map keys are order-independent. (Closed)

Description

Patch Set 1 #

Patch Set 2 : code review #

Messages