Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 297343005: Don't expect anything about 404 responseText (Closed)

Created:
6 years, 6 months ago by ahe
Modified:
6 years, 6 months ago
Reviewers:
ricow1, Emily Fortuna
CC:
reviews_dartlang.org, vsm
Visibility:
Public.

Description

Don't expect anything about 404 responseText Committed: https://code.google.com/p/dart/source/detail?r=36689

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M dart/tests/html/xhr_test.dart View 1 chunk +4 lines, -1 line 2 comments Download

Messages

Total messages: 6 (0 generated)
ahe
6 years, 6 months ago (2014-05-27 15:32:27 UTC) #1
ahe
Committed patchset #1 manually as r36689 (presubmit successful).
6 years, 6 months ago (2014-05-27 15:50:50 UTC) #2
Emily Fortuna
https://codereview.chromium.org/297343005/diff/20001/dart/tests/html/xhr_test.dart File dart/tests/html/xhr_test.dart (right): https://codereview.chromium.org/297343005/diff/20001/dart/tests/html/xhr_test.dart#newcode31 dart/tests/html/xhr_test.dart:31: // We cannot say much about xhr.responseText, most HTTP ...
6 years, 6 months ago (2014-05-27 15:55:35 UTC) #3
ahe
https://codereview.chromium.org/297343005/diff/20001/dart/tests/html/xhr_test.dart File dart/tests/html/xhr_test.dart (right): https://codereview.chromium.org/297343005/diff/20001/dart/tests/html/xhr_test.dart#newcode31 dart/tests/html/xhr_test.dart:31: // We cannot say much about xhr.responseText, most HTTP ...
6 years, 6 months ago (2014-05-27 15:59:09 UTC) #4
Emily Fortuna
On 2014/05/27 15:59:09, ahe wrote: > https://codereview.chromium.org/297343005/diff/20001/dart/tests/html/xhr_test.dart > File dart/tests/html/xhr_test.dart (right): > > https://codereview.chromium.org/297343005/diff/20001/dart/tests/html/xhr_test.dart#newcode31 > ...
6 years, 6 months ago (2014-05-27 16:02:32 UTC) #5
ahe
6 years, 6 months ago (2014-05-27 16:29:32 UTC) #6
Message was sent while issue was closed. 
On 2014/05/27 16:02:32, Emily Fortuna wrote:
> Gotcha. The reason I asked was if there were a change to the server, I
would've
> expected to see it as part of the CL (or a link). 

Yes. I failed to test my change to the server before submitting, luckily, this
seems to be the only issue.

Powered by Google App Engine
This is Rietveld 408576698