Reinstall previous behavior for Set and Queue toString.

Reinstall previous behavior for Set and Queue toString.

A previous change made these omit elements to keep the toString length down.
That could break code that expects the original behavior.

This still avoids using IterableMixinWorkaround.

Add static toString methods on ListBase, SetBase, IterableBase so that users can
get the same behavior as our toString methods, and with the same cycle detection
safety.

Unify all collection toString methods in two methods:
- IterableBase.iterableToShortString
- IterableBase.iterableToFullString

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36616

[Lasse Reichstein Nielsen, 2014-05-23 15:45:48]

https://codereview.chromium.org/297053002/diff/20001/tests/corelib/collection...
File tests/corelib/collection_to_string_test.dart (right):

https://codereview.chromium.org/297053002/diff/20001/tests/corelib/collection...
tests/corelib/collection_to_string_test.dart:1: // Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
This file is just a revert of the previous change.

https://codereview.chromium.org/297053002/diff/20001/tests/corelib/collection...
tests/corelib/collection_to_string_test.dart:15: // TODO(jjb): seed random
number generator when API allows it
Should we seed it now?

[floitsch, 2014-05-23 16:09:58]

LGTM, although I'm not really sold on the names of the two new exposed
functions.
Will think if I can come up with better ones.

https://codereview.chromium.org/297053002/diff/20001/runtime/lib/array.dart
File runtime/lib/array.dart (right):

https://codereview.chromium.org/297053002/diff/20001/runtime/lib/array.dart#n...
runtime/lib/array.dart:16: String toString() => ListBase.listToString(this);
runtime/lib files preferred to avoid the "=>" syntax.
Not sure if that has changed.

https://codereview.chromium.org/297053002/diff/20001/sdk/lib/collection/itera...
File sdk/lib/collection/iterable.dart (right):

https://codereview.chromium.org/297053002/diff/20001/sdk/lib/collection/itera...
sdk/lib/collection/iterable.dart:408: String toString() =>
IterableBase.iterableToShortString(this, '(', ')');
-IterableBase.-

https://codereview.chromium.org/297053002/diff/20001/sdk/lib/collection/itera...
sdk/lib/collection/iterable.dart:418: static String
iterableToShortString(Iterable iterable,
Isn't this an exposed class?
Do you want to expose "iterableToShortString" ?

https://codereview.chromium.org/297053002/diff/20001/sdk/lib/collection/itera...
sdk/lib/collection/iterable.dart:452: static String
iterableToFullString(Iterable iterable,
ditto.

https://codereview.chromium.org/297053002/diff/20001/sdk/lib/collection/itera...
sdk/lib/collection/iterable.dart:477: * inside the try/finally.
This should not be a dart-doc comment.

Feel free to leave it as a normal comment below the dart-doc, though.

[Lasse Reichstein Nielsen, 2014-05-23 16:50:01]

https://codereview.chromium.org/297053002/diff/20001/runtime/lib/array.dart
File runtime/lib/array.dart (right):

https://codereview.chromium.org/297053002/diff/20001/runtime/lib/array.dart#n...
runtime/lib/array.dart:16: String toString() => ListBase.listToString(this);
I have no problem using brackets instead.

https://codereview.chromium.org/297053002/diff/20001/sdk/lib/collection/itera...
File sdk/lib/collection/iterable.dart (right):

https://codereview.chromium.org/297053002/diff/20001/sdk/lib/collection/itera...
sdk/lib/collection/iterable.dart:408: String toString() =>
IterableBase.iterableToShortString(this, '(', ')');
You mean I should remove it?
It is in the same class now, so I guess it's safe.

https://codereview.chromium.org/297053002/diff/20001/sdk/lib/collection/itera...
sdk/lib/collection/iterable.dart:418: static String
iterableToShortString(Iterable iterable,
Yes, I want to expose it.
I see no reason to have perfectly good functionality unexposed.
We think it's a reasonable default toString on Iterable, but we haven't made it
possible to use it on a Set or List, even if you wanted it (well, you could wrap
it in something that exposed the Set's iterator and used IterableMixin's
toString, but there is no easy way).

This way a user can decide to have a short, but still cycle-safe, toString of
their Set, like the default on IterableBase.

And no, the name isn't perfect. It's intended for programmers wanting to
implement some sub-type of Iterable, so it'll likely be hidden behind a more
meaningfull name (like toString). If you want to use it for debugging, that's
cool too.

https://codereview.chromium.org/297053002/diff/20001/sdk/lib/collection/itera...
sdk/lib/collection/iterable.dart:452: static String
iterableToFullString(Iterable iterable,
And yes, intended public.
I don't want anybody to ever cook up their own toString over a subclass of
Iterable and forget to handle cycles.

https://codereview.chromium.org/297053002/diff/20001/sdk/lib/collection/itera...
sdk/lib/collection/iterable.dart:477: * inside the try/finally.
On 2014/05/23 16:09:58, floitsch wrote:
> This should not be a dart-doc comment.

Why not. It's a private method, so it won't be exposed on api.dartlang.org, but
I sure hope the editor will show it as tooltip on the call, if you are editing
this file.

> Feel free to leave it as a normal comment below the dart-doc, though.

[Lasse Reichstein Nielsen, 2014-05-26 06:09:07]

Committed patchset #3 manually as r36616 (presubmit successful).