sdk/lib/_internal/lib/js_array.dart - Issue 297053002: Reinstall previous behavior for Set and Queue toString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/js_array.dart

Issue 297053002: Reinstall previous behavior for Set and Queue toString. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/lib/js_array.dart

diff --git a/sdk/lib/_internal/lib/js_array.dart b/sdk/lib/_internal/lib/js_array.dart

index 730d063c1141f1cc047a4daf88909369af6ba04b..42ee24859b918c2df43df42a0122ddb96e258772 100644

--- a/sdk/lib/_internal/lib/js_array.dart

+++ b/sdk/lib/_internal/lib/js_array.dart

@@ -326,7 +326,7 @@ class JSArray<E> extends Interceptor implements List<E>, JSIndexable {

bool get isNotEmpty => !isEmpty;

- String toString() => IterableMixinWorkaround.toStringIterable(this, '[', ']');

+ String toString() => ListBase.listToString(this);

List<E> toList({ bool growable: true }) {

if (growable) {

« no previous file with comments | « runtime/lib/typed_data.dart ('k') | sdk/lib/collection/hash_set.dart » ('j') | no next file with comments »