Issue 296743004: Fix a bug that caused the fix in r36391 not to work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296743004: Fix a bug that caused the fix in r36391 not to work. (Closed)

Created:
6 years, 7 months ago by nweiz

Modified:
6 years, 7 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix a bug that caused the fix in r36391 not to work. The first phase in a group considered itself idle even if the previous phase was running, since it had no contents. R=jmesserly@google.com BUG=18872 Committed: https://code.google.com/p/dart/source/detail?r=36398

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -2 lines)			Patch
M	pkg/barback/CHANGELOG.md	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/barback/lib/src/graph/phase.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/barback/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Jennifer Messerly

lgtm. add a test for this one? or is covered by an existing test?

6 years, 7 months ago (2014-05-20 22:33:55 UTC) #2

nweiz

On 2014/05/20 22:33:55, John Messerly wrote: > lgtm. add a test for this one? or ...

6 years, 7 months ago (2014-05-20 22:43:33 UTC) #3

nweiz

6 years, 7 months ago (2014-05-20 22:43:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r36398 (presubmit successful).