pkg/barback/lib/src/graph/phase.dart - Issue 296743004: Fix a bug that caused the fix in r36391 not to work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/barback/lib/src/graph/phase.dart

Issue 296743004: Fix a bug that caused the fix in r36391 not to work. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/barback/lib/src/graph/phase.dart

diff --git a/pkg/barback/lib/src/graph/phase.dart b/pkg/barback/lib/src/graph/phase.dart

index 6043125cf99c0c26f1d3637a4f5a6f305e1561c0..a4724ab20e22f0ef3c0c2f4aff84f96842fc272a 100644

--- a/pkg/barback/lib/src/graph/phase.dart

+++ b/pkg/barback/lib/src/graph/phase.dart

@@ -87,7 +87,7 @@ class Phase {

NodeStatus get status {

// Before any transformers are added, the phase should be dirty if and only

// if any input is dirty.

- if (_classifiers.isEmpty && _groups.isEmpty) {

+ if (_classifiers.isEmpty && _groups.isEmpty && previous == null) {

return _inputs.any((input) => input.state.isDirty) ?

NodeStatus.RUNNING : NodeStatus.IDLE;

}

« no previous file with comments | « pkg/barback/CHANGELOG.md ('k') | pkg/barback/pubspec.yaml » ('j') | no next file with comments »