Issue 296513012: Dart2js: Fix object leaking between isolates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296513012: Dart2js: Fix object leaking between isolates. (Closed)

Created:
6 years, 7 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 7 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Dart2js: Fix object leaking between isolates. BUG= http://dartbug.com/18942 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=36484

Patch Set 1 #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -0 lines)			Patch
	M	sdk/lib/_internal/lib/isolate_helper.dart	View		1 chunk	+2 lines, -0 lines	2 comments	Download
	A	tests/isolate/object_leak_test.dart	View		1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/296513012/diff/1/sdk/lib/_internal/lib/isolate_helper.dart File sdk/lib/_internal/lib/isolate_helper.dart (right): https://codereview.chromium.org/296513012/diff/1/sdk/lib/_internal/lib/isolate_helper.dart#newcode960 sdk/lib/_internal/lib/isolate_helper.dart:960: args = _serializeMessage(args); // Or just args.toList() ? ...

6 years, 7 months ago (2014-05-22 09:43:09 UTC) #2

Lasse Reichstein Nielsen

Committed patchset #1 manually as r36484 (presubmit successful).

6 years, 7 months ago (2014-05-22 11:09:44 UTC) #3

Lasse Reichstein Nielsen

6 years, 7 months ago (2014-05-22 11:11:24 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/296513012/diff/1/sdk/lib/_internal/lib/isolat...
File sdk/lib/_internal/lib/isolate_helper.dart (right):

https://codereview.chromium.org/296513012/diff/1/sdk/lib/_internal/lib/isolat...
sdk/lib/_internal/lib/isolate_helper.dart:960: args = _serializeMessage(args); 
// Or just args.toList() ?
A good idea for another CL.

Expand Messages | Collapse Messages