Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: sdk/lib/_internal/lib/isolate_helper.dart

Issue 296513012: Dart2js: Fix object leaking between isolates. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/isolate/object_leak_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/lib/isolate_helper.dart
diff --git a/sdk/lib/_internal/lib/isolate_helper.dart b/sdk/lib/_internal/lib/isolate_helper.dart
index 0a6bcb7799490c662b794787f17bb8d86587f804..cfb0a96d6b29e04db6760038aad96a41cd24c736 100644
--- a/sdk/lib/_internal/lib/isolate_helper.dart
+++ b/sdk/lib/_internal/lib/isolate_helper.dart
@@ -956,6 +956,8 @@ class IsolateNatives {
throw new UnsupportedError(
"Currently spawnUri is not supported without web workers.");
}
+ message = _serializeMessage(message);
+ args = _serializeMessage(args); // Or just args.toList() ?
floitsch 2014/05/22 09:43:09 We can't just write `toList()` unless we verify th
Lasse Reichstein Nielsen 2014/05/22 11:11:24 A good idea for another CL.
_globalState.topEventLoop.enqueue(new _IsolateContext(), () {
final func = _getJSFunctionFromName(functionName);
_startIsolate(func, args, message, isSpawnUri, startPaused, replyPort);
« no previous file with comments | « no previous file | tests/isolate/object_leak_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698