Fix code to determine root directory when using Safari.

Fix code to determine root directory when using Safari.

Remove unsupported --unsafe-angular2-whitelist parameter.

BUG=
R=jakemac@google.com, vsm@google.com

Committed: https://github.com/dart-lang/pub/commit/5d55544673cdaf781e15241f55a311d6d446ac15

[Jacob, 2017-06-12 17:45:48]

jacobr@google.com changed reviewers:
+ jakemac@google.com

[Jacob, 2017-06-12 17:45:49]

Also fixes
https://github.com/dart-lang/pub/issues/1583

[vsm, 2017-06-12 19:54:14]

vsm@google.com changed reviewers:
+ vsm@google.com

[vsm, 2017-06-12 19:54:15]

lgtm

[jakemac, 2017-06-12 19:54:22]

https://codereview.chromium.org/2939453002/diff/1/lib/src/dartdevc/dartdevc.dart
File lib/src/dartdevc/dartdevc.dart (left):

https://codereview.chromium.org/2939453002/diff/1/lib/src/dartdevc/dartdevc.d...
lib/src/dartdevc/dartdevc.dart:304: // TODO(jakemac53): Remove when no longer
needed,
Did you confirm we don't need this any more? Does it require the new compiler?

[Jacob, 2017-06-12 20:01:03]

On 2017/06/12 19:54:22, jakemac wrote:
>
https://codereview.chromium.org/2939453002/diff/1/lib/src/dartdevc/dartdevc.dart
> File lib/src/dartdevc/dartdevc.dart (left):
> 
>
https://codereview.chromium.org/2939453002/diff/1/lib/src/dartdevc/dartdevc.d...
> lib/src/dartdevc/dartdevc.dart:304: // TODO(jakemac53): Remove when no longer
> needed,
> Did you confirm we don't need this any more? Does it require the new compiler?

The flag has now been completely removed from tip of trunk DDC. DDC fails to
even start if this flag is set.

I don't think the new angular compiler is required. Generally the main purpose
of the flag was to improve runtime performance not to work around Angular code
with type errors.

[vsm, 2017-06-12 20:02:47]

On 2017/06/12 20:01:03, Jacob wrote:
> On 2017/06/12 19:54:22, jakemac wrote:
> >
>
https://codereview.chromium.org/2939453002/diff/1/lib/src/dartdevc/dartdevc.dart
> > File lib/src/dartdevc/dartdevc.dart (left):
> > 
> >
>
https://codereview.chromium.org/2939453002/diff/1/lib/src/dartdevc/dartdevc.d...
> > lib/src/dartdevc/dartdevc.dart:304: // TODO(jakemac53): Remove when no
longer
> > needed,
> > Did you confirm we don't need this any more? Does it require the new
compiler?
> 
> The flag has now been completely removed from tip of trunk DDC. DDC fails to
> even start if this flag is set.
> 
> I don't think the new angular compiler is required. Generally the main purpose
> of the flag was to improve runtime performance not to work around Angular code
> with type errors.

We removed this flag internally before the new angular compiler dropped.

[kevmoo, 2017-06-12 20:05:26]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2017-06-12 20:05:27]

DBC

https://codereview.chromium.org/2939453002/diff/1/lib/src/dartdevc/dartdevc.dart
File lib/src/dartdevc/dartdevc.dart (left):

https://codereview.chromium.org/2939453002/diff/1/lib/src/dartdevc/dartdevc.d...
lib/src/dartdevc/dartdevc.dart:304: // TODO(jakemac53): Remove when no longer
needed,
On 2017/06/12 19:54:22, jakemac wrote:
> Did you confirm we don't need this any more? Does it require the new compiler?

I think this was dropped. Ping Jenny

[Jacob, 2017-06-12 20:18:43]

On 2017/06/12 20:05:27, kevmoo wrote:
> DBC
> 
>
https://codereview.chromium.org/2939453002/diff/1/lib/src/dartdevc/dartdevc.dart
> File lib/src/dartdevc/dartdevc.dart (left):
> 
>
https://codereview.chromium.org/2939453002/diff/1/lib/src/dartdevc/dartdevc.d...
> lib/src/dartdevc/dartdevc.dart:304: // TODO(jakemac53): Remove when no longer
> needed,
> On 2017/06/12 19:54:22, jakemac wrote:
> > Did you confirm we don't need this any more? Does it require the new
compiler?
> 
> I think this was dropped. Ping Jenny

It has been dropped.

[jakemac, 2017-06-12 20:33:12]

lgtm

[Jacob, 2017-06-12 20:34:15]

Description was changed from

==========
Fix code to determine root directory when using Safari.

Remove unsupported --unsafe-angular2-whitelist parameter.

BUG=
==========

to

==========
Fix code to determine root directory when using Safari.

Remove unsupported --unsafe-angular2-whitelist parameter.

BUG=
R=jakemac@google.com, vsm@google.com

Committed:
https://github.com/dart-lang/pub/commit/5d55544673cdaf781e15241f55a311d6d446ac15
==========

[Jacob, 2017-06-12 20:34:17]

Committed patchset #1 (id:1) manually as
5d55544673cdaf781e15241f55a311d6d446ac15 (presubmit successful).