Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1357)

Unified Diff: lib/src/dartdevc/dartdevc.dart

Issue 2939453002: Fix code to determine root directory when using Safari. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/dartdevc/dartdevc.dart
diff --git a/lib/src/dartdevc/dartdevc.dart b/lib/src/dartdevc/dartdevc.dart
index 43a10928299add4c9f9ed4d929ede475ab0501bd..e887aaf52485a9c23761d6b14be5a88bf28781c9 100644
--- a/lib/src/dartdevc/dartdevc.dart
+++ b/lib/src/dartdevc/dartdevc.dart
@@ -37,7 +37,8 @@ var _currentDirectory = (function () {
match = lines[1].match(/^\s+at.+\((.+):\d+:\d+\)$/);
if (match) return match[1];
// Firefox.
- return lines[0].match(/[<][@](.+):\d+:\d+$/)[1];
+ match = lines[0].match(/[<][@](.+):\d+:\d+$/)
+ if (match) return match[1];
}
// Safari.
return lines[0].match(/(.+):\d+:\d+$/)[1];
@@ -301,9 +302,6 @@ Map<AssetId, Future<Asset>> createDartdevcModule(
var request = new WorkRequest();
request.arguments.addAll([
'--dart-sdk-summary=$sdk_summary',
- // TODO(jakemac53): Remove when no longer needed,
jakemac 2017/06/12 19:54:22 Did you confirm we don't need this any more? Does
kevmoo 2017/06/12 20:05:27 I think this was dropped. Ping Jenny
- // https://github.com/dart-lang/pub/issues/1583.
- '--unsafe-angular2-whitelist',
'--modules=amd',
'--dart-sdk=${sdkDir.path}',
'--module-root=${scratchSpace.tempDir.path}',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698