Fix issue 18834. Collect stack trace before the frame is prepared for OSR.

Fix issue 18834. Collect stack trace before the frame is prepared for OSR.

Otherwise there is a mismatch between PC in the frame and the PC marker.

R=turnidge@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36413

[turnidge, 2014-05-20 16:52:24]

lgtm with one question

https://codereview.chromium.org/292173005/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/292173005/diff/1/runtime/vm/code_generator.cc...
runtime/vm/code_generator.cc:1115: DeoptimizeAll();
If I deoptimize here and then attempt to osr below, will things work out okay?

[srdjan, 2014-05-20 18:13:32]

DBC

https://codereview.chromium.org/292173005/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/292173005/diff/1/runtime/vm/code_generator.cc...
runtime/vm/code_generator.cc:1074: FLAG_stacktrace_every > 0) {
This fits in one line, and add parentheses please.

https://codereview.chromium.org/292173005/diff/1/runtime/vm/code_generator.cc...
runtime/vm/code_generator.cc:1080: (count % FLAG_deoptimize_every) == 0) {
Add parantheses

https://codereview.chromium.org/292173005/diff/1/runtime/vm/code_generator.cc...
runtime/vm/code_generator.cc:1084: (count % FLAG_stacktrace_every) == 0) {
ditto

https://codereview.chromium.org/292173005/diff/1/runtime/vm/code_generator.cc...
runtime/vm/code_generator.cc:1089: FLAG_stacktrace_filter != NULL) {
ditto

https://codereview.chromium.org/292173005/diff/1/runtime/vm/code_generator.cc...
runtime/vm/code_generator.cc:1101: strstr(function_name, FLAG_deoptimize_filter)
!= NULL) {
ditto

https://codereview.chromium.org/292173005/diff/1/runtime/vm/code_generator.cc...
runtime/vm/code_generator.cc:1107: strstr(function_name, FLAG_stacktrace_filter)
!= NULL) {
ditto

[Florian Schneider, 2014-05-21 09:28:58]

https://codereview.chromium.org/292173005/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/292173005/diff/1/runtime/vm/code_generator.cc...
runtime/vm/code_generator.cc:1074: FLAG_stacktrace_every > 0) {
On 2014/05/20 18:13:32, srdjan wrote:
> This fits in one line, and add parentheses please.

Done.

https://codereview.chromium.org/292173005/diff/1/runtime/vm/code_generator.cc...
runtime/vm/code_generator.cc:1115: DeoptimizeAll();
On 2014/05/20 16:52:25, turnidge wrote:
> If I deoptimize here and then attempt to osr below, will things work out okay?

Yes, I think so. The function triggering OSR is unoptimized so it should not be
affected by DeoptimizeAll().

[Florian Schneider, 2014-05-21 09:33:33]

Committed patchset #1 manually as r36413 (presubmit successful).