Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: runtime/vm/debugger.cc

Issue 292173005: Fix issue 18834. Collect stack trace before the frame is prepared for OSR. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/code_generator.cc ('K') | « runtime/vm/code_generator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
===================================================================
--- runtime/vm/debugger.cc (revision 36356)
+++ runtime/vm/debugger.cc (working copy)
@@ -1186,22 +1186,12 @@
ActivationFrame* Debugger::CollectDartFrame(Isolate* isolate,
uword pc,
StackFrame* frame,
- const Code& code_param,
+ const Code& code,
const Array& deopt_frame,
intptr_t deopt_frame_offset,
ActivationFrame* callee_activation,
const Context& entry_ctx) {
- // TODO(turnidge): Remove the workaround below once...
- // https://code.google.com/p/dart/issues/detail?id=18384
- // ...is fixed.
- Code& code = Code::Handle(isolate);
- code = code_param.raw();
- if (!code.ContainsInstructionAt(pc)) {
- code = Code::LookupCode(pc);
- ASSERT(!code.IsNull());
- ASSERT(code.ContainsInstructionAt(pc));
- }
-
+ ASSERT(code.ContainsInstructionAt(pc));
// We provide either a callee activation or an entry context. Not both.
ASSERT(((callee_activation != NULL) && entry_ctx.IsNull()) ||
((callee_activation == NULL) && !entry_ctx.IsNull()));
« runtime/vm/code_generator.cc ('K') | « runtime/vm/code_generator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698