Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 289003003: Fix remaining RequestDatum tests. (Closed)

Created:
6 years, 7 months ago by Paul Berry
Modified:
6 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix remaining RequestDatum tests. There were a few problems: - An expression like "x is List<Foo>" doesn't guarantee that every element of x is of type Foo. We need to check item by item. Similar for maps. - InvalidParameterResponseMatcher was failing to account for the fact that the response gets wrapped in a RequestFailure object. - Tests weren't calling setUp(). R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=36237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -41 lines) Patch
M pkg/analysis_server/lib/src/protocol.dart View 5 chunks +38 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 8 chunks +40 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Berry
6 years, 7 months ago (2014-05-15 17:12:16 UTC) #1
Brian Wilkerson
LGTM
6 years, 7 months ago (2014-05-15 18:11:48 UTC) #2
Paul Berry
Committed patchset #1 manually as r36237 (presubmit successful).
6 years, 7 months ago (2014-05-15 20:03:57 UTC) #3
danrubel
6 years, 7 months ago (2014-05-15 20:22:03 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698