Fix remaining RequestDatum tests.

pkg/analysis_server/lib/src/protocol.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library protocol;
 
 import 'dart:convert' show JsonDecoder;
 
 /**
  * Instances of the class [Request] represent a request that was received.
@@ skipping 155 matching lines @@
    * Create a RequestDatum for decoding and validating [datum], which refers to
    * [request] in any errors it reports.
    */
   RequestDatum(this.request, this.path, this.datum);
 
   /**
    * Validate that the datum is a Map containing the given [key], and return
    * a [RequestDatum] containing the corresponding value.
    */
   RequestDatum operator [](String key) {
-    if (datum is! Map<String, dynamic>) {
+    if (datum is! Map) {
       throw new RequestFailure(new Response.invalidParameter(request, path,
           "be a map"));
     }
     if (!datum.containsKey(key)) {
       throw new RequestFailure(new Response.invalidParameter(request, path,
           "contain key '$key'"));
     }
     return new RequestDatum(request, "$path.$key", datum[key]);
   }
 
   /**
    * Return `true` if the datum is a Map containing the given [key].
    */
   bool hasKey(String key) {
-    if (datum is! Map<String, dynamic>) {
+    if (datum is! Map) {
       throw new RequestFailure(new Response.invalidParameter(request, path,
           "be a map"));
     }
     return datum.containsKey(key);
   }
 
   /**
    * Validate that the datum is a Map whose keys are strings, and call [f] on
    * each key/value pair in the map.
    */
   void forEachMap(void f(String key, RequestDatum value)) {
-    if (datum is! Map<String, dynamic>) {
+    if (datum is! Map) {
       throw new RequestFailure(new Response.invalidParameter(request, path,
           "be a map"));
     }
     datum.forEach((String key, dynamic value) {
       f(key, new RequestDatum(request, "$path.$key", value));
     });
   }
 
   /**
    * Validate that the datum is an integer (or a string that can be parsed
@@ skipping 36 matching lines @@
    */
   String asString() {
     if (datum is! String) {
       throw new RequestFailure(new Response.invalidParameter(request, path,
           "be a string"));
     }
     return datum;
   }
 
   /**
+   * Determine if the datum is a list of strings.
+   */
+  bool isStringList() {
+    if (datum is! List) {
+      return false;
+    }
+    for (var element in datum) {
+      if (element is! String) {
+        return false;
+      }
+    }
+    return true;
+  }
+
+  /**
    * Validate that the datum is a list of strings, and return it.
    */
   List<String> asStringList() {
-    if (datum is! List<String>) {
+    if (!isStringList()) {
       throw new RequestFailure(new Response.invalidParameter(request, path,
           "be a list of strings"));
     }
     return datum;
   }
 
   /**
+   * Determine if the datum is a map whose values are all strings.
+   *
+   * Note: we can safely assume that the keys are all strings, since JSON maps
+   * cannot have any other key type.
+   */
+  bool isStringMap() {
+    if (datum is! Map) {
+      return false;
+    }
+    for (var value in datum.values) {
+      if (value is! String) {
+        return false;
+      }
+    }
+    return true;
+  }
+
+  /**
    * Validate that the datum is a map from strings to strings, and return it.
    */
   Map<String, String> asStringMap() {
-    if (datum is! Map<String, String>) {
+    if (!isStringMap()) {
       throw new RequestFailure(new Response.invalidParameter(request, path,
           "be a string map"));
     }
     return datum;
   }
 }
 
 /**
  * Instances of the class [Response] represent a response to a request.
  */
@@ skipping 419 matching lines @@
   /**
    * The response to be returned as a result of the failure.
    */
   final Response response;
 
   /**
    * Initialize a newly created exception to return the given reponse.
    */
   RequestFailure(this.response);
 }