Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 285123002: Fix analyzer errors in html Dartium. (Closed)

Created:
6 years, 7 months ago by Emily Fortuna
Modified:
6 years, 7 months ago
Reviewers:
Leaf, kevmoo
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Fix analyzer errors in html Dartium. BUG= R=leafp@google.com Committed: https://code.google.com/p/dart/source/detail?r=36191

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -294 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +89 lines, -89 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +87 lines, -90 lines 0 comments Download
M tests/lib/analyzer/analyze_library.status View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
M tools/dom/src/WrappedEvent.dart View 1 1 chunk +0 lines, -90 lines 0 comments Download
A + tools/dom/src/dart2js_WrappedEvent.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/dom/src/dartium_CustomElementSupport.dart View 1 chunk +2 lines, -1 line 2 comments Download
A + tools/dom/src/dartium_WrappedEvent.dart View 1 1 chunk +0 lines, -4 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 2 chunks +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Emily Fortuna
Partial fix for dartbug.com/16524
6 years, 7 months ago (2014-05-14 18:28:07 UTC) #1
Leaf
https://codereview.chromium.org/285123002/diff/80001/sdk/lib/_blink/dartium/_blink_dartium.dart File sdk/lib/_blink/dartium/_blink_dartium.dart (right): https://codereview.chromium.org/285123002/diff/80001/sdk/lib/_blink/dartium/_blink_dartium.dart#newcode7206 sdk/lib/_blink/dartium/_blink_dartium.dart:7206: if ((blob_OR_source_OR_stream is MediaSource || blob_OR_source_OR_stream == null)) { ...
6 years, 7 months ago (2014-05-14 21:42:08 UTC) #2
Emily Fortuna
PTAL https://codereview.chromium.org/285123002/diff/80001/sdk/lib/_blink/dartium/_blink_dartium.dart File sdk/lib/_blink/dartium/_blink_dartium.dart (right): https://codereview.chromium.org/285123002/diff/80001/sdk/lib/_blink/dartium/_blink_dartium.dart#newcode7206 sdk/lib/_blink/dartium/_blink_dartium.dart:7206: if ((blob_OR_source_OR_stream is MediaSource || blob_OR_source_OR_stream == null)) ...
6 years, 7 months ago (2014-05-14 21:49:53 UTC) #3
Leaf
lgtm
6 years, 7 months ago (2014-05-14 21:53:30 UTC) #4
Emily Fortuna
Committed patchset #4 manually as r36191 (presubmit successful).
6 years, 7 months ago (2014-05-14 21:54:46 UTC) #5
kevmoo
DBQ https://codereview.chromium.org/285123002/diff/100001/tools/dom/src/dartium_CustomElementSupport.dart File tools/dom/src/dartium_CustomElementSupport.dart (right): https://codereview.chromium.org/285123002/diff/100001/tools/dom/src/dartium_CustomElementSupport.dart#newcode34 tools/dom/src/dartium_CustomElementSupport.dart:34: return null; Are there issues w/ returning null ...
6 years, 7 months ago (2014-05-14 22:27:48 UTC) #6
Emily Fortuna
6 years, 7 months ago (2014-05-14 23:05:26 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/285123002/diff/100001/tools/dom/src/dartium_C...
File tools/dom/src/dartium_CustomElementSupport.dart (right):

https://codereview.chromium.org/285123002/diff/100001/tools/dom/src/dartium_C...
tools/dom/src/dartium_CustomElementSupport.dart:34: return null;
On 2014/05/14 22:27:49, kevmoo wrote:
> Are there issues w/ returning null here?
> 
> Does this break anything?

It previously returned null but it was erroneously "fixed" in this CL:
https://codereview.chromium.org/265833008/

Powered by Google App Engine
This is Rietveld 408576698