tools/dom/src/dartium_CustomElementSupport.dart - Issue 285123002: Fix analyzer errors in html Dartium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/src/dartium_CustomElementSupport.dart

Issue 285123002: Fix analyzer errors in html Dartium. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/src/dartium_CustomElementSupport.dart

diff --git a/tools/dom/src/dartium_CustomElementSupport.dart b/tools/dom/src/dartium_CustomElementSupport.dart

index 3afc56ae4f26580000b18c05fbc3a1430e3f6b8e..37baa5595d7e6967706ee3dfd28ca15434bb1ff2 100644

--- a/tools/dom/src/dartium_CustomElementSupport.dart

+++ b/tools/dom/src/dartium_CustomElementSupport.dart

@@ -30,7 +30,8 @@ class _VMElementUpgrader implements ElementUpgrader {

if (element.runtimeType != _nativeType) {

throw new UnsupportedError('Element is incorrect type');

}

- return _Utils.changeElementWrapper(element, _type);

+ _Utils.changeElementWrapper(element, _type);

+ return null;

kevmoo 2014/05/14 22:27:49 Are there issues w/ returning null here? Does thi

Emily Fortuna 2014/05/14 23:05:26 It previously returned null but it was erroneously

}

« no previous file with comments | « tools/dom/src/dart2js_WrappedEvent.dart ('k') | tools/dom/src/dartium_WrappedEvent.dart » ('j') | no next file with comments »